Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmc-solid: Apply cross-build prefix by prefix_for_target instead of special-casing in get_base_compiler #692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kawadakk
Copy link
Contributor

@kawadakk kawadakk commented Jul 6, 2022

This PR changes how the tool names are determined for the *-kmc-solid_* Tier 3 targets and thereby fixes ar being invoked without a cross-build prefix.

The cross build prefixes for these targets are arm-kmc-eabi and aarch64-kmc-elf. In the current version of cc-rs, these prefixes are added to a compiler command-line by SOLID-specific code in get_base_compiler, but no prefixes are added to an archiver (ar) command-line. This happened to work in certain versions of the SOLID standard toolchain that provided prefix-less aliases, but according to the toolchain's maintainer, their usage is discouraged.

This PR removes the special case in get_base_compiler and instead defines the cross build prefixes in prefix_for_target, the common subroutine that provides cross build prefixes for all purposes.

@kawadakk kawadakk force-pushed the patch/kmc-solid/cross-build-prefix branch from 73490b9 to 8ebe400 Compare November 1, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant