Add new compile_intermediates function. #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I won't be able to take a look at this until the weekend. |
roblabla
force-pushed
the
compile-intermediates
branch
2 times, most recently
from
1b35617
to
51af4a6
Compare
NobodyXu
requested changes
Jan 3, 2024
roblabla
force-pushed
the
compile-intermediates
branch
2 times, most recently
from
469c86d
to
9675445
Compare
NobodyXu
requested changes
Jan 3, 2024
NobodyXu
requested changes
Jan 3, 2024
roblabla
force-pushed
the
compile-intermediates
branch
from
9675445
to
1316b84
Compare
NobodyXu
requested changes
Jan 3, 2024
|
pinging @roblabla just in case you forgot this PR/comment |
This new function can be used to just compile the files to a bunch of .o files.
Since rust-lang#684 was merged, it is impossible for `obj` to not start with dst - if `obj` is absolute or contains `../` in its Path, then the path will be hashed, and the file will still be placed under dst. As such, this obj.starts_with(&dst) check is always true.
roblabla
force-pushed
the
compile-intermediates
branch
from
cbe0137
to
463febc
Compare
NobodyXu
requested changes
Jan 24, 2024
roblabla
force-pushed
the
compile-intermediates
branch
from
ba180b4
to
4d11c28
Compare
roblabla
force-pushed
the
compile-intermediates
branch
from
4d11c28
to
d493b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function can be used to just compile the files to a bunch of .o files. It won't create an archive file, nor print any of the cargo link directives. This is meant to be used by rustc to:
crtbegin.chereCurrently, rustc guesses the output path of the object files, even though it's an unexposed implementation detail of
cc. The latest version ofccadded some hash to the generated object file name, which broke rustc's assumptions.By providing a proper way to generate an object file using
cc, this should hopefully make the system more robust.Fixes #912