Allow cross-compiling outside of build.rs#242
Open
madsmtm wants to merge 2 commits intorust-lang:mainfrom
Open
Allow cross-compiling outside of build.rs#242madsmtm wants to merge 2 commits intorust-lang:mainfrom
build.rs#242madsmtm wants to merge 2 commits intorust-lang:mainfrom
Conversation
Do not expect CARGO_CFG_TARGET_OS/CARGO_CFG_TARGET_ARCH to always be available, and instead try to determine this information based on the rustc target tuple.
SamuelMarks
reviewed
Jun 30, 2025
| /// | ||
| /// [`CMAKE_SYSTEM_NAME`]: https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_NAME.html | ||
| fn get_system_name(target: &str) -> &'static str { | ||
| let mapping = [ |
There was a problem hiding this comment.
If you get bored and want more names take my https://github.com/offscale/osbuild/blob/master/src/distribution.c#L15-L130
Member
|
Would this interact with #193? |
Contributor
Author
It would. I'll admit that I'm too unfamiliar with CMake to know what is the best solution to cross-compilation. |
Member
You and me both. I'm trying to gather as much context as I can but tbh I'm not sure how much progress I'll make before needing to turn my attention elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reliance on
CARGO_CFG_TARGET_OS/CARGO_CFG_TARGET_ARCHwas introduced in #158, but these are not available when outsidebuild.rsscripts. Instead, we should try to determineCMAKE_SYSTEM_NAMEandCMAKE_SYSTEM_PROCESSORbased on the target triple.In
cc-rs, we do this by parsing the target triple, though I suspect that to be overkill forcmake-rs' purposes, so I've tried to keep it simpler.It's doable for
CMAKE_SYSTEM_NAMEbut kinda difficult forCMAKE_SYSTEM_PROCESSOR, because the values expected that aren't really documented, so it's hard to know if we emit it correctly? In any case, I've written it in a way that the user can overrideCMAKE_SYSTEM_PROCESSORif necessary.Fixes #228.
bootstrapcurrently has to work around this in rust-lang/rust#138784.