Add __powitf2 symbol for f128 integer exponentiation#614
Merged
tgross35 merged 3 commits intorust-lang:masterfrom Sep 28, 2024
Merged
Add __powitf2 symbol for f128 integer exponentiation#614tgross35 merged 3 commits intorust-lang:masterfrom
__powitf2 symbol for f128 integer exponentiation#614tgross35 merged 3 commits intorust-lang:masterfrom
Conversation
tgross35
changed the title
__powitf2 symbol for f128 powi__powitf2 symbol for f128 integer exponentation
tgross35
changed the title
__powitf2 symbol for f128 integer exponentation__powitf2 symbol for f128 integer exponentiation
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
May 16, 2024
This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
May 16, 2024
This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
Contributor
Author
|
Blocked until we have the function in libs, rust-lang/rust#125188 |
Qadeem411
approved these changes
May 17, 2024
Contributor
Author
|
Lol @Qadeem411 I have to imagine you didn’t mean to approve this |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2024
Add `powi` fo `f16` and `f128` This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
tgross35
force-pushed
the
f16-f128-powi
branch
7 times, most recently
from
65841d8 to
9550d45
Compare
Contributor
Author
|
WIndows targets appear to fail compiling this crate because powi uses the f128 multiply and divide in its implementation, and these are not available. I don't know why only Windows has the issue, but other platforms without these available natively (e.g. aarch darwin) do not, must be slightly different linkage rules. How should I handle this @Amanieu? |
Member
|
I think this just happens to work before libgcc provides these symbols, but that's not available on -msvc targets. You'll need to implement a fallback for that target for testing, at least temporarily. |
tgross35
force-pushed
the
f16-f128-powi
branch
3 times, most recently
from
fdb0fd1 to
241b9a8
Compare
Contributor
Author
|
It looks like I can make this work by recreating |
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
Add `powi` fo `f16` and `f128` This will unblock adding support to compiler_builtins (<rust-lang/compiler-builtins#614>), which will then unblock adding tests for these new functions.
92 tasks
Merged
tgross35
force-pushed
the
f16-f128-powi
branch
2 times, most recently
from
fbf79c0 to
f74817b
Compare
tgross35
force-pushed
the
f16-f128-powi
branch
from
61980c6 to
e5407f7
Compare
tgross35
force-pushed
the
f16-f128-powi
branch
5 times, most recently
from
5798bc3 to
74f2fb6
Compare
Contributor
Author
|
This should be ready for a look when you get the chance @Amanieu |
Amanieu
approved these changes
Sep 28, 2024
Member
Amanieu
left a comment
Amanieu
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge it either now (and enable it with MSVC later) or after a boostrap bump.
Contributor
Author
|
Thanks! rust-lang/rust#130792 hasn't been picked up yet so I might as well just update that to include this. |
tgross35
force-pushed
the
f16-f128-powi
branch
from
74f2fb6 to
2738d63
Compare
Create the symbol `__powitf2`.
tgross35
force-pushed
the
f16-f128-powi
branch
from
2738d63 to
31c4a8e
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 28, 2024
This includes the following which add `__divtf3` and `__powtf2`, and do some feature cleanup: - rust-lang/compiler-builtins#622 - rust-lang/compiler-builtins#692 - rust-lang/compiler-builtins#614 - rust-lang/compiler-builtins#694 The `cc` bump [1] was previously included but was reverted due to problems updating. [1]: rust-lang/compiler-builtins#690
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 28, 2024
This includes the following which add `__divtf3` and `__powtf2`, and do some feature cleanup: - rust-lang/compiler-builtins#622 - rust-lang/compiler-builtins#692 - rust-lang/compiler-builtins#614 - rust-lang/compiler-builtins#694 The `cc` bump [1] was previously included but was reverted due to problems updating. [1]: rust-lang/compiler-builtins#690
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
Update compiler-builtins to 0.1.130 This includes the following which add `__divtf3` and `__powtf2`, and do some feature cleanup: - rust-lang/compiler-builtins#622 - rust-lang/compiler-builtins#692 - rust-lang/compiler-builtins#614 - rust-lang/compiler-builtins#694 The `cc` bump [1] was previously included but was reverted due to problems updating. [1]: rust-lang/compiler-builtins#690
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Oct 3, 2024
Update compiler-builtins to 0.1.130 This includes the following which add `__divtf3` and `__powtf2`, and do some feature cleanup: - rust-lang/compiler-builtins#622 - rust-lang/compiler-builtins#692 - rust-lang/compiler-builtins#614 - rust-lang/compiler-builtins#694 The `cc` bump [1] was previously included but was reverted due to problems updating. [1]: rust-lang/compiler-builtins#690
tgross35
added a commit
that referenced
this pull request
Jan 31, 2026
Add `__powitf2` symbol for `f128` integer exponentiation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.