Closed
Conversation
Contributor
Author
|
Split this off of #622 so it should be easier to figure out the |
Contributor
Author
|
Benchmarked just to make sure this didn't regress anything, changes are within noise tolerance for both f32 and f64. |
Currently there are two separate functions for for `f32` and `f64`. Combine them and extract some repeated functionality to a trait, which will make adding `f128` easier.
Contributor
Author
|
#622 is actually getting closer so I don't think there is any need to have this on its own anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are two separate functions for for
f32andf64. Combine them and extract some repeated functionality to a trait, which will make addingf128easier.