Enable `f16` for LoongArch#770

Merged

tgross35 merged 2 commits intorust-lang:masterfrom

heiher:enable-f16-loong

Mar 5, 2025

Contributor

heiher commented Feb 26, 2025

Tracking issue for f16: rust-lang/rust#116909

Contributor

tgross35 commented Feb 26, 2025

Since loongarch doesn't have the system version to test against, could you add a line here so it uses the apfloat fallback

compiler-builtins/testcrate/build.rs

Line 59 in 453da66

|| target.arch == "powerpc64le"

?

Contributor Author

heiher commented Feb 26, 2025

Since loongarch doesn't have the system version to test against, could you add a line here so it uses the apfloat fallback

compiler-builtins/testcrate/build.rs

Line 59 in 453da66

|| target.arch == "powerpc64le"

?

Thanks for your suggestion.

heiher mentioned this pull request

Enable f16 for LoongArch rust-lang/rust#137674

Merged

Contributor

tgross35 commented Mar 4, 2025

This should be good but I'm holding off since our compiler-builtins updates are a bit backed up.

tgross35 reviewed

View reviewed changes

testcrate/tests/conv.rs Show resolved Hide resolved

Contributor

tgross35 commented Mar 5, 2025

I guess it is looking for those unmangled convert symbols to implement the other routines rather than only testing our __gnu_(h2f|f2h)_ieee. So you were right before, disabling the tests in testcrate/tests/conv.rs is probably the best thing to do until this makes it to a nightly rustc, then we can enable them again. Sorry about that.

Contributor Author

heiher commented Mar 5, 2025

I guess it is looking for those unmangled convert symbols to implement the other routines rather than only testing our __gnu_(h2f|f2h)_ieee. So you were right before, disabling the tests in testcrate/tests/conv.rs is probably the best thing to do until this makes it to a nightly rustc, then we can enable them again. Sorry about that.

Okay. I'll revert to the previous version, and I also sincerely appreciate your efforts in this.

tgross35 approved these changes

View reviewed changes

Contributor

tgross35 commented Mar 5, 2025

Happy to help get the type working on more targets 👍 thanks for all the changes.

I have to hold off merging until rust-lang/rust#137634 goes through but LGTM.

heiher added 2 commits

March 5, 2025 01:07


          Enable f16 for LoongArch

657512b


          Skip the f16-related tests on LoongArch

f7f3c19

Skip the f16-related tests on LoongArch if there are no f16 symbols
in the system libraries.

tgross35 enabled auto-merge (rebase)

March 5, 2025 06:07

tgross35 disabled auto-merge

March 5, 2025 06:07

tgross35 enabled auto-merge (squash)

March 5, 2025 06:08

tgross35 merged commit 4690673 into rust-lang:master

26 checks passed

github-actions bot mentioned this pull request

chore: release v0.1.151 #777

Merged

heiher deleted the enable-f16-loong branch

March 5, 2025 06:37

tgross35 added a commit to tgross35/rust that referenced this pull request


          Update compiler-builtins to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

tgross35 mentioned this pull request

Update compiler-builtins to 0.1.151 rust-lang/rust#138038

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#138038 - tgross35:update-builtins, r=<try>

2e5cd7c

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

jieyouxu added a commit to jieyouxu/rust that referenced this pull request


          Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

78d2633

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

jieyouxu added a commit to jieyouxu/rust that referenced this pull request


          Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

d2cdf5e

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

Noratrieb added a commit to Noratrieb/rust that referenced this pull request


          Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

7ad72f4

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

compiler-errors added a commit to compiler-errors/rust that referenced this pull request


          Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

071bc46

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#138038

Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#137674 - heiher:enable-f16-loong, r=<try>

66aec18

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? `@tgross35`

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request


          Rollup merge of #138038 - tgross35:update-builtins, r=tgross35

45b598f

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? `@tgross35`

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ``@tgross35``

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

6e7d135

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ```@tgross35```

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#137674

1a4bd2a

Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ```@tgross35```

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request


          Rollup merge of #138038 - tgross35:update-builtins, r=tgross35

081fc3d

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request


          Update compiler-builtins to 0.1.151

75485a2

This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Update compiler-builtins to 0.1.151

87d5004

This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

e2b4056

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

982f369

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ```@tgross35```

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request


          Update compiler-builtins to 0.1.151

f5e3d7f

This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request


          Rollup merge of #138038 - tgross35:update-builtins, r=tgross35

1907a2b

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request


          Update compiler-builtins to 0.1.151

c10e589

This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request


          Rollup merge of #138038 - tgross35:update-builtins, r=tgross35

b3efc73

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl

tgross35 pushed a commit that referenced this pull request


          Enable f16 for LoongArch (#770)

333ae6f

[ the configured-out tests should be re-enabled once we have the symbols
  in nightly - Trevor ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet