Disable conduit_log_requests in production

[sgrif]

Everything it outputs is redundant with heroku's router logging. We're
hitting our usage limits for log storage, so let's cut them down by
half.

[jtgeibel]

I definitely support getting rid of the logging at this level since it includes a lot of redundant data when requests succeed. Before we can do that, I think we need to first add logging of error results elsewhere as there have been some recent issues where this log output helped identify the root cause:

• 1296 - 500: entity not found No such file or directory (os error 2)
• 1327 - 500: didn't get a 200 result from github, got 401 with: ...

I've added a commit to #1301 which will log any unexpected errors propagated up the middleware stack. Additionally it includes the request id provided by Heroku when the X-Request-ID header is present.

[sgrif]

Heroku's built in logging includes both of those from what I can see.

[jtgeibel]

For the log snippets included in those issues, the line provided by conduit_log_requests is the only one including the details of the error as far as I can see. I don't have access to the full logs so maybe I'm missing something.

[sgrif]

Ironically I just got paged for a spike in error rates, and you're right, heroku's router doesn't have the response body. I'm just going to change our log level to error instead.

[jtgeibel]

I'm just going to change our log level to error instead.

I'm not quite sure I follow. Are you saying production was using something like RUST_LOG=info before?

[sgrif]

It was. It isn't now

…

On Sat, Apr 14, 2018, 9:53 PM Justin Geibel ***@***.***> wrote: I'm just going to change our log level to error instead. I'm not quite sure I follow. Are you saying production was using something like RUST_LOG=info before? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1349 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdWKxjpc2rD6oZ5U6iqVxfQSDSjDVe_ks5tosRJgaJpZM4TT8NM> .

[jtgeibel]

Okay, makes sense. I've opened conduit-rust/conduit-log-requests#4 as I think including the request ID from Heroku would be the last advantage to adding our own logging middleware for catching unexpected errors.