Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/token: Move name check outside of spawn_blocking() callback #9574

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

There is no need to spin up a worker thread for basic data validation.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) October 4, 2024 08:34
@Turbo87 Turbo87 merged commit d15cf42 into rust-lang:main Oct 4, 2024
8 checks passed
@Turbo87 Turbo87 deleted the name-check branch October 4, 2024 08:45
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (2e5a4fe) to head (89b8ce9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9574      +/-   ##
==========================================
- Coverage   89.07%   89.06%   -0.01%     
==========================================
  Files         286      286              
  Lines       28940    28938       -2     
==========================================
- Hits        25779    25775       -4     
- Misses       3161     3163       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant