Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/on_call: Convert Event::send() to async fn #9581

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

One less thing using reqwest::blocking 🎉

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (429e1be) to head (9e8eb30).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/test_pagerduty.rs 0.00% 14 Missing ⚠️
src/bin/monitor.rs 0.00% 10 Missing ⚠️
src/admin/on_call.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9581      +/-   ##
==========================================
+ Coverage   88.90%   88.92%   +0.02%     
==========================================
  Files         289      289              
  Lines       29123    29117       -6     
==========================================
+ Hits        25892    25893       +1     
+ Misses       3231     3224       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit e32ad30 into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-pagerduty branch October 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant