This repository was archived by the owner on May 23, 2024. It is now read-only.
Merged
Conversation
Member
|
rust-lang/rust#108339 doesn't seem like an ICE issue. |
ritikmishra
force-pushed
the
2023-11-03-add-some-ice
branch
from
393ea0f to
bcba3fe
Compare
Contributor
Author
|
my bad - it was supposed to be rust-lang/rust#108399 |
JohnTitor
reviewed
Mar 12, 2023
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
JohnTitor
approved these changes
Mar 12, 2023
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Thanks a lot!
Overall LGTM, fixed style and removed one non-ICE issue.
Some tips for next time:
- Format code with rustfmt and add the main function if possible; this work is helpful when we move code to rust-lang/rust's regression tests.
- Check if the issue is already resolved, this can be checked by
cargo run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f32to same ident withconstandletrust#108683Fn-family trait and closure rust#108814Failed to normalizeclosure with TAIT rust#109020