Implement Serialize and Deserialize from serde in Pattern#174
Closed
kailan wants to merge 1 commit intorust-lang:masterfrom
Closed
Implement Serialize and Deserialize from serde in Pattern#174kailan wants to merge 1 commit intorust-lang:masterfrom
Serialize and Deserialize from serde in Pattern#174kailan wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
I don't think we want this functionality: the usecase is niche, and we may not have the internal
|
Contributor
|
With the above in mind, I am going to close this and the issue: it is reasonably straightforward to reconstruct a glob from the deserialized string. Thank you for the submission! |
Author
|
Yep, that makes sense. Thank you for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to load glob patterns from a configuration file but got an error as there is no
Deserializeimplementation forPattern.This change adds a
serdefeature to the crate that enables an implementation ofserde::Serializeandserde::Deserializeon thePatternstruct.Closes #136.