Use getrandom for randomness#110
Merged
weihanglo merged 1 commit intorust-lang:mainfrom Mar 26, 2025
ChrisDenton:getrandom
Merged
Use getrandom for randomness#110weihanglo merged 1 commit intorust-lang:mainfrom ChrisDenton:getrandom
weihanglo merged 1 commit intorust-lang:mainfrom
ChrisDenton:getrandom
Conversation
|
@weihanglo Would it be possible to get a new release of |
Merged
Member
|
jobserver@0.1.33 is out. |
This was referenced Apr 7, 2025
lsegal
added a commit
to qltysh/qlty
that referenced
this pull request
May 16, 2025
GHA builds are failing due to a linker issue, this was resolved by rust-lang/jobserver-rs#110
lsegal
added a commit
to qltysh/qlty
that referenced
this pull request
May 16, 2025
GHA builds are failing due to a linker issue, this was resolved by rust-lang/jobserver-rs#110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason
getrandomisn't currently used is given by:jobserver-rs/src/windows.rs
Lines 71 to 76 in f494d82
getrandomcan't be used due to rust-lang/rust#65014 which was closed as an instance of rust-lang/cargo#4866 which is closed in favour of a nightly cargo feature rust-lang/cargo#7915 which has since been stabilised.So I think we're good now.