Keep file descriptors inherited by default#65
Draft
belovdv wants to merge 2 commits intorust-lang:mainfrom
Draft
Keep file descriptors inherited by default#65belovdv wants to merge 2 commits intorust-lang:mainfrom
belovdv wants to merge 2 commits intorust-lang:mainfrom
Conversation
323e098 to
3951e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #64:
Then jobserver is initialized from pipe, it sets cloexec, but doesn't delete environment variable which points to file descriptors. By default (unless
Client::configureis used), child process will be instructed (if it uses jobserver) to access file descriptors that was closed and maybe reopened to point to other files.This seems like a violation of IO-safety.
Either cloexec shouldn't be set or the environment variables should also be removed and only be added back via
configure.This pr is aimed to implement first option.
Concerns:
Reasons to choose first option:
Concerns:
Client::newin current pr's code changes global state - env var.Notes:
SECURITY_ATTRIBUTES::bInheritHandleand does nothing inClient::configure. According to learn.microsoft.com, the handle cannot be inherited by child processes.