Fix big-endian build and add CI tests for it.#103
Merged
wesleywiser merged 3 commits intorust-lang:masterfrom Jan 2, 2020
Merged
Fix big-endian build and add CI tests for it.#103wesleywiser merged 3 commits intorust-lang:masterfrom
wesleywiser merged 3 commits intorust-lang:masterfrom
Conversation
Member
Author
|
But it fails before it can even install Rust |
aa79938 to
a93ebad
Compare
Member
|
measureme/measureme/src/raw_event.rs Lines 152 to 153 in 560162a is |
Member
Author
|
Yes, that's the error. I'm tweaking |
a93ebad to
fdb2267
Compare
Member
|
Oh, sorry. I didn't realize what was going on. Carry on! 🙂 |
Member
Author
|
Alright, ready for review |
wesleywiser
approved these changes
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
cargo checkbuild to CI, so we catch compilation errors like these early next time0.7.1so we can use that to unblock self-profiling: Support recording query keys rust#67397.This PR should fail until the big endian specific error uncovered here is fixed.