Shim intrinsics::atomic_singlethreadfence, etc.#1150
Conversation
|
Can these be triggered from code using just the libstd? If so, please add a test invoking some of them |
|
👍 tests added |
|
Thanks! @bors r+ |
|
📌 Commit 9265e0c has been approved by |
Shim intrinsics::atomic_singlethreadfence, etc. This applies the no-op shim for atomic fences to `atomic_singlethreadfence` and related intrinsics.
|
☀️ Test successful - checks-travis, status-appveyor |
|
@RalfJung Can we submit a PR to get this into nightly? I would do it myself, but from memory last time it is easier if you are the owner of the PR in case further fixes are needed :) |
|
Since miri is still passing on rustc master, you should be able to just open a PR that bumps the submodule and ping ralf and me so one of us can send it off. Most of the time we just update when there's breakage, so you may have seen that? |
|
Will do! I just remember the experience from rust-lang/rust#65278 (which was also "just a bump"), and wanted to avoid repeating that :p |
|
Done in rust-lang/rust#68576 |
update miri Bump miri for rust-lang/miri#1150 r? @oli-obk
5 participants
This applies the no-op shim for atomic fences to
atomic_singlethreadfenceand related intrinsics.