Replace target.target with target#1583
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 15, 2020
Merged
Conversation
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2020
No more target.target Two main changes of this PR: * Turn `target_pointer_width` into an integer and rename to `pointer_width`. The compiler only allowed three valid values for the width anyways. An integer is more natural for this value, and saves a few allocations and copies. * Remove the `rustc_session::config::Config` wrapper and replace it with its inner member `Target`. Aka. no more `target.target`. This makes life so much easier, but it also causes a ton of downstream breakage. Some changes of this PR were done using tooling. These tooling-made changes were isolated to their own commits to make review easier. It's best to review the PR commit-by-commit. Miri PR: rust-lang/miri#1583 I request p=10 bors priority because of the breakage.
est31
force-pushed
the
target_refactor
branch
from
210db0e to
5f670b2
Compare
Rustc removed the target wrapper and exposed the target directly.
Result of running:
find . -type f -exec sed -i -e 's/target\.target\([)\.,;]\)/target\1/g' {} \;
Plus one manual edit of the rust-version file
est31
force-pushed
the
target_refactor
branch
from
5f670b2 to
1ae157b
Compare
Member
|
Thanks. :) |
Contributor
|
📌 Commit 1ae157b has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions, checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fallout caused by rustc PR: rust-lang/rust#77943
Fixes rust-lang/rust#77988