Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
stdarchimplemented this function in terms of primitives miri can already evaluate. To work around a performance regressionstdarchnow uses the llvm intrinsic again. In zlib-rs we rely on miri being able to evaluate this function.I've already fixed the LLVM bug, so in LLVM 22 we should be able to remove the shim, but the test coverage is still useful to ensure there are no further regressions.
I've only hooked up the avx512 version. I could add the sse2/avx2 variants too, but if nobody has complained about them yet it's just adding code that we'll remove in ~2 months.
I validated the test on real hardware.
cc rust-lang/stdarch#1985