Repository navigation
remove some of miri's public re-exports - #5412
Merged
Merged
Conversation
mejrs
force-pushed
the
reexports
branch
2 times, most recently
from
October 12, 2026 12:03
9433168 to
4d90593
Compare
RalfJung
reviewed
Oct 12, 2026
| //! metadata we remembered when pushing said frame. | ||
|
|
||
| use rustc_abi::ExternAbi; | ||
| use rustc_log::tracing::trace; |
Member
There was a problem hiding this comment.
I'm okay with having fewer things pub-exported in the crate root, but I am not okay with having to import the trace macro in every single file. That's just useless boilerplate IMO.
RalfJung
reviewed
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way the docs for rustc, miri, clippy, rustdoc, etc are smooshed together, these re-exports used to override the original definitions in search results, see for example span_bug:
This has been mildly annoying me for some time, so i figured I'd just fix up these imports.