Fix static linking against libbsd on ubuntu#180
Closed
mrdomino wants to merge 1 commit intorust-lang:masterfrom
Closed
Fix static linking against libbsd on ubuntu#180mrdomino wants to merge 1 commit intorust-lang:masterfrom
mrdomino wants to merge 1 commit intorust-lang:masterfrom
Conversation
I noticed that I was getting a shared dependency on libbsd.so from a
package using pkg-config recently, and it seems to be due to this
changed line; the Ubuntu libbsd pkg-config name is `libbsd`, so
previously `is_static_available` would look for `liblibbsd`.
At a glance, it seems like a few different libraries have `libfoo.pc` as
libbsd does, so I’ve proposed the following change, just adding `{}.a`
to the list after `lib{}.a`.
Author
|
Huh, actually, this does not fix it. Here is an example log: I’d expect that line to be But it is not (nor is it in a local checkout that has pkg-config-rs with this change in it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that I was getting a shared dependency on
libbsd.sofrom a package using pkg-config recently, and it seems to be due to this changed line; the Ubuntu libbsd pkg-config name islibbsd, so previouslyis_static_availablewould look forliblibbsd.At a glance, it seems like a few different libraries have
libfoo.pcas libbsd does, so I’ve proposed the following change, just adding{}.ato the list afterlib{}.a.