Allow disabling passing --cflags to pkg-config.#183
Open
teo-tsirpanis wants to merge 1 commit intorust-lang:masterfrom
Open
Allow disabling passing --cflags to pkg-config.#183teo-tsirpanis wants to merge 1 commit intorust-lang:masterfrom
--cflags to pkg-config.#183teo-tsirpanis wants to merge 1 commit intorust-lang:masterfrom
Conversation
teo-tsirpanis
force-pushed
the
probe-cflags
branch
from
9da2520 to
863a0fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to disable passing the
--cflagsoption to pkg-config. Passing--cflagscauses private requirements to be resolved (which might not exist if the package is a shared library), and is arguably not always useful in languages other than C/C++.