Filter reflexive subset relations eagerly#177
Filter reflexive subset relations eagerly#177ecstatic-morse wants to merge 2 commits intorust-lang:masterfrom
Conversation
| &dying_can_reach_live, | ||
| |&(_origin2, _point1, point2), &origin1, &origin3| ((origin1, point2), origin3), | ||
| |&(_origin2, _point1, point2), &origin1, &origin3| { | ||
| (origin1 != origin3).then(|| ((origin1, point2), origin3)) |
There was a problem hiding this comment.
Personally not a big fan of bool::then, but I don't mind if you and the others like it.
There was a problem hiding this comment.
I quite like it. If you and/or Niko find it too obtuse, we can change it of course.
|
This is how I envisioned we would do this in the end, so this looks good to me once we publish a datafrog release including rust-lang/datafrog#37. Do you remember if such predicates are accepted by Soufflé btw ? So that we can potentially extract datalog rules from our comments/book and easily run them with it (which is one of the reason they are (intended to be) written with upper-cased variables for example, and not the rust-like naming that they used to have). Doesn't matter much if it doesn't support it, maybe we just add the symmetry-removing predicate as a comment rather than part of the rule, or not. |
|
Souffle supports inequality as a predicate, along with many others, so that shouldn't be an issue. I like that it makes the rules correspond directly to the |
...instead of removing them at the start of each iteration.
ecstatic-morse
force-pushed
the
filter-symmetries-eagerly
branch
from
ac7f36d to
a6dbde6
Compare
|
I don't know the context here, but FYI, Soufflé has no requirements on the case of variables, you can even use the same identifier for the type and the attribute: i.e. |
|
Force pushed with |
3 participants
Depends on rust-lang/datafrog#37.
Filter reflexive
subsetrelations before they are added to therecenttuples list.