improve trait object doc #1443
Draft
improve trait object doc #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wiseaidev: We notice this is still a draft PR. Do you still plan to move this forward? In skimming the draft, this seems to add a lot of examples. While we like examples, this is probably too many. There's also some language that maybe tries a bit too hard to sell the language. E.g. "is a powerful concept", and similar. We're also a bit unclear about where the confusion is that's motivating this work. Perhaps you could explain better here, in the PR description what the motivation is, and what the nature of the confusion is that you're trying to resolve with these changes. |
ehuss
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #392