Add note about static libraries not linking their dependencies #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're reviewing this in the the rustdocs call, and we're not sure about it. @petrochenkov: What do you think about this one? |
petrochenkov
reviewed
Jul 3, 2024
petrochenkov
approved these changes
Jul 3, 2024
Co-authored-by: Vadim Petrochenkov <[email protected]>
traviscross
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks @petrochenkov for having a look. If it looks good to you, then it looks good to me, and we'll merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confused me for a while, but this is just fundamentally how static libraries work.
Wading through some history on this, I think when specifying
--crate-type=staticlib, rustc used to output the--print=native-static-libsnote by default, but it doesn't anymore, so let's document it instead!