Update behavior-considered-undefined.md #1476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traviscross
reviewed
Jun 18, 2024
| @@ -119,7 +119,7 @@ omitted in surface Rust syntax due to automatic dereferencing; we are | |||
| considering the fully expanded place expression here.) | |||
|
|
|||
| For instance, if `ptr` has type `*const S` where `S` has an alignment of 8, then | |||
| `ptr` must be 8-aligned or else `(*ptr).f` is "based on an misaligned pointer". | |||
| `*ptr` must be 8-aligned or else `(*ptr).f` is "based on an misaligned pointer". | |||
There was a problem hiding this comment.
Suggested change
| `*ptr` must be 8-aligned or else `(*ptr).f` is "based on an misaligned pointer". | |
| the address contained in `ptr` must be cleanly divisible by 8 or else `(*ptr).f` is "based on an misaligned pointer". |
On the rustdocs call today we spent a lot of time trying to determine whether or not this was correct or an improvement. Maybe there's a better way to say this more explicitly that relies less on notation?
The ambiguity all comes from whether we're talking about where the pointer is stored or whether we're talking about the address contained in the pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.