Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdbook-spec #1520

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Add mdbook-spec #1520

merged 9 commits into from
Jul 4, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 1, 2024

This adds the use of mdbook-spec for the reference. The intent is to support some extensions that will help with the formatting that we eventually want to add, and to make authoring easier. Most of the changes are described in authoring.md.

This includes several changes split into separate commits. This includes a sync of the authoring document which was over in the rust-lang/spec repo.

This includes some tentative example changes in the CSS, but those will certainly want to change over time (particularly to support different theme colors). These aren't quite being used, yet. The current formatting of the reference should be identical as to before this PR. I will follow up with future PRs to do additional changes, such as removing explicit std links.

This will require some changes in rust-lang/rust in order to work properly, which I will handle before the next book sync.

ehuss added 4 commits July 2, 2024 13:42
This preprocessor adds support for several Markdown extensions that
should assist with writing.
The next commit will update to keep in sync with the reference.
@ehuss
Copy link
Contributor Author

ehuss commented Jul 2, 2024

For more context: It is noted that it is not optimal to have mdbook-spec in a separate repo. The reasons are complicated, due to the way the documentation is published. This is just intended as a short-term solution to unblock progress. Later I will try to figure out something so that we can move it to this repo and make it easier to develop and use.

This link section was already sorted but for a recent change (that
understandably probably preferred to keep the diff contained).  Let's
restore the sort order of the links here.
The CONTRIBUTING guide seems wrapped at 80 character lines.  Let's
rewrap a paragraph with a line that had overflowed.
Let's follow our own rules in the authoring guide by, e.g., using
`---` rather than the Unicode em-dash character, not wrapping lines,
specifying the language for code block sections, etc.

To improve formatting, we broke out some descriptions that were in
code block sections into the main text.  We replaced references to
"the spec" with "the reference" for consistency, as that's what most
of this document uses.  And we made some other small editorial
improvements.
These two items of style were the only bits present in the style guide
and missing from the authoring guide.  Let's copy them over, since
they are true of the Reference, and this will let us delete the style
guide entirely.
The authoring guide now fully incorporates and supersedes the style
guide, so let's simply link to that from the style guide.
@traviscross traviscross added this pull request to the merge queue Jul 4, 2024
Merged via the queue into rust-lang:master with commit aa99472 Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants