Extend `iter_on` lints to catch more cases by Centri3 · Pull Request #11038 · rust-lang/rust-clippy

Centri3 · 2023-06-27T14:54:52Z

I've moved this to pedantic, unfortunately not style as there are still a few FPs that need to be sorted out.

changelog: Enhancement: [iter_on_single_items], [iter_on_empty_collections]: Catch more cases

rustbot · 2023-06-27T14:54:57Z

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

dswij · 2023-06-29T08:20:22Z

as there are still a few FPs that need to be sorted out.

Can you list out the FPs to be sorted out? Will be good if we track them in an issue.

@blyxyas Can you help to review this one? 😄

r? @blyxyas

Centri3 · 2023-06-29T08:22:12Z

Oh I meant with the new implementation, they're all annotated with #[expect]. I know why but I'm having trouble fixing it :/

https://github.com/Centri3/rust-clippy/blob/401797bbae28b88bfcc7c3089af09b5cb4bb90c0/tests/ui/iter_on_empty_collections.fixed#L26-L31
https://github.com/Centri3/rust-clippy/blob/401797bbae28b88bfcc7c3089af09b5cb4bb90c0/clippy_lints/src/methods/single_or_empty_collections_iter.rs#L135-L136

blyxyas · 2023-06-29T16:20:14Z

Yeah, I'll review it once we know what FP got fixed 😅
Yeehaw 🤠

bors · 2023-07-13T13:10:57Z

☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts.

Centri3 · 2023-07-14T05:13:33Z

I gave making the get_expr_use_or_unification_node check work another try but I still have no idea why it isn't working...

clippy_lints/src/methods/mod.rs

clippy_lints/src/methods/single_or_empty_collections_iter.rs

bors · 2023-07-23T18:53:28Z

☔ The latest upstream changes (presumably #11166) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-07-24T14:35:23Z

☔ The latest upstream changes (presumably #11031) made this pull request unmergeable. Please resolve the merge conflicts.

clippy_lints/src/methods/single_or_empty_collections_iter.rs

dswij · 2023-07-25T19:59:58Z

Assigning this to you since you've taken a look and have review privilege now

r? @blyxyas

blyxyas · 2023-07-26T12:18:02Z

rust-lang/rust#114070 was accepted, please wait until the next sync (which will also change Clippy's toolchain version) to do this change (it won't work before that :) ). It will sync about 2 or 3 days from now AFAIK.

Add `sym::iter_mut` + `sym::as_mut_ptr` for Clippy We currently have `sym::iter` and `sym::iter_repeat`, this PR adds `sym::iter_mut` as it's useful for rust-lang/rust-clippy#11038 and another Clippy lint, it also adds `sym::as_mut_ptr` as it's useful for rust-lang/rust-clippy#10962.

Add `sym::iter_mut` + `sym::as_mut_ptr` for Clippy We currently have `sym::iter` and `sym::iter_repeat`, this PR adds `sym::iter_mut` as it's useful for rust-lang#11038 and another Clippy lint, it also adds `sym::as_mut_ptr` as it's useful for rust-lang#10962.

bors · 2023-07-28T22:12:49Z

☔ The latest upstream changes (presumably #11250) made this pull request unmergeable. Please resolve the merge conflicts.

blyxyas · 2023-07-29T12:55:45Z

Good news! #11250 got merged, merging 0404b6b (#11250), the change can now be made :)

Centri3 · 2023-08-01T06:15:00Z

Only 2 more FPs before this can (probably) be uplifted to style:
https://github.com/Centri3/rust-clippy/blob/324f80605db74c5e5d48e808e114f126ba272357/clippy_lints/src/types/mod.rs#L512
https://github.com/Centri3/rust-clippy/blob/324f80605db74c5e5d48e808e114f126ba272357/clippy_utils/src/lib.rs#L540
(really 3, but the 3rd is the same issue as the first)

blyxyas · 2023-08-08T09:28:12Z

Forgot to ask, I assumed that you wanted to fix those 2 FPs and uplift all in this PR. Do you wish to fix those in a future PR? Is this ready for another review?

Centri3 · 2023-08-08T15:36:57Z

Yeah this is ready for another, I think the 2nd was caused by this rewrite so I intend to fix that but I'm unsure about the other. Ideally both would be fixed in this PR

blyxyas

Just some finishing touches and I think this is pretty ready.

blyxyas · 2023-08-08T23:44:50Z

clippy_lints/src/methods/mod.rs

+    /// Checks for calls to `iter`, `iter_mut` or `into_iter` on collections containing a single item.
    ///
    /// ### Why is this bad?
+    /// It is simpler to use the once function from the standard library.


Suggested change

/// It is simpler to use the once function from the standard library.

/// It is simpler to use the [`once`](https://doc.rust-lang.org/std/iter/fn.once.html) function from the standard library.

blyxyas · 2023-08-08T23:50:27Z

clippy_lints/src/methods/mod.rs

+    /// ### Known problems
+    /// The type of the resulting iterator might become incompatible with its usage.


It should probably mention the reason, that it is a core::iter::sources::once::Once<T> instead of a core::slice::iter::Iter<T>, but it should work fine as Once also implements Iterator

blyxyas · 2023-08-08T23:51:17Z

clippy_lints/src/methods/mod.rs

    ///
-    /// It is simpler to use the empty function from the standard library:
+    /// ### Known problems
+    /// The type of the resulting iterator might become incompatible with its usage.


(Same as comment above 🐮 )

blyxyas · 2023-08-09T00:04:31Z

Also, I didn't really understand: Will you work on this PR to fix those FPs, or open another PR in the future uplifting this lint to style?

Centri3 · 2023-08-09T00:08:45Z

Ideally, yes, I want this to be style after this PR if possible

bors · 2023-08-11T15:48:36Z

☔ The latest upstream changes (presumably #11239) made this pull request unmergeable. Please resolve the merge conflicts.

xFrednet · 2024-03-31T11:42:05Z

Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D

Thank you to @Centri3 and the reviewers for the time, that you already put into this!

@rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review

rustbot assigned dswij Jun 27, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 27, 2023

Centri3 changed the title ~~Extend iter_on to catch more cases~~ Extend iter_on lints to catch more cases Jun 27, 2023

Centri3 force-pushed the option_iter_v2 branch from 5385139 to 401797b Compare June 27, 2023 14:58

rust-lang deleted a comment from rustbot Jun 29, 2023

Centri3 force-pushed the option_iter_v2 branch from 401797b to 8b8bea6 Compare July 14, 2023 05:12

blyxyas requested changes Jul 14, 2023

View reviewed changes

clippy_lints/src/methods/mod.rs Show resolved Hide resolved

clippy_lints/src/methods/single_or_empty_collections_iter.rs Outdated Show resolved Hide resolved

clippy_lints/src/methods/single_or_empty_collections_iter.rs Outdated Show resolved Hide resolved

Centri3 force-pushed the option_iter_v2 branch from 8b8bea6 to d77a4ac Compare July 23, 2023 19:29

Centri3 force-pushed the option_iter_v2 branch from d77a4ac to 31ee767 Compare July 25, 2023 19:37

blyxyas reviewed Jul 25, 2023

View reviewed changes

clippy_lints/src/methods/single_or_empty_collections_iter.rs Outdated Show resolved Hide resolved

clippy_lints/src/methods/single_or_empty_collections_iter.rs Outdated Show resolved Hide resolved

rustbot assigned blyxyas and unassigned dswij Jul 25, 2023

blyxyas mentioned this pull request Jul 25, 2023

Add sym::iter_mut + sym::as_mut_ptr for Clippy rust-lang/rust#114070

Merged

Centri3 force-pushed the option_iter_v2 branch from 31ee767 to 6c6d350 Compare July 25, 2023 20:40

Extend iter_on lints to catch more cases

324f806

Centri3 force-pushed the option_iter_v2 branch from 6c6d350 to 324f806 Compare August 1, 2023 06:13

blyxyas approved these changes Aug 9, 2023

View reviewed changes

rust-lang deleted a comment from bors Sep 20, 2023

xFrednet closed this Mar 31, 2024

rustbot added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2024

Centri3 mentioned this pull request May 16, 2024

iter_on_empty_collections's suggestion causes a compilation error #12807

Closed

	/// It is simpler to use the once function from the standard library.
	/// It is simpler to use the [`once`](https://doc.rust-lang.org/std/iter/fn.once.html) function from the standard library.

		/// ### Known problems
		/// The type of the resulting iterator might become incompatible with its usage.

Conversation

Centri3 commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 27, 2023

Uh oh!

dswij commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centri3 commented Jun 29, 2023

Uh oh!

blyxyas commented Jun 29, 2023

Uh oh!

bors commented Jul 13, 2023

Uh oh!

Centri3 commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Jul 23, 2023

Uh oh!

bors commented Jul 24, 2023

Uh oh!

Uh oh!

Uh oh!

dswij commented Jul 25, 2023

Uh oh!

blyxyas commented Jul 26, 2023

Uh oh!

bors commented Jul 28, 2023

Uh oh!

blyxyas commented Jul 29, 2023

Uh oh!

Centri3 commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blyxyas commented Aug 8, 2023

Uh oh!

Centri3 commented Aug 8, 2023

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

blyxyas Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

blyxyas Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

blyxyas Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

blyxyas commented Aug 9, 2023

Uh oh!

Centri3 commented Aug 9, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

xFrednet commented Mar 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Centri3 commented Jun 27, 2023 •

edited

Loading

dswij commented Jun 29, 2023 •

edited

Loading

Centri3 commented Jul 14, 2023 •

edited

Loading

Centri3 commented Aug 1, 2023 •

edited

Loading