New lints [manual_is_infinite] and [manual_is_finite]

[Centri3]

Closes #9665

changelog: New lints [manual_is_infinite] and [manual_is_finite]
#11049

[rustbot]

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #11020) made this pull request unmergeable. Please resolve the merge conflicts.

[asquared31415]

x != <float>::INFINITY && x != <float>::NEG_INFINITY returns true for NaN where is_finite returns false.

[Centri3]

Almost nobody would intentionally account for NaN in those cases regardless. Should add a note about || x.is_nan(), though, and change to MaybeIncorrect

[Centri3]

We could probably suggest either !x.is_infinite() or x.is_finite() in that case, depending on what they wanted (the original code's behavior or the "fixed" version, respectively). Though x.is_infinite() || x.is_nan() may be more readable than !x.is_infinite()

[xFrednet]

r ? @blyxyas

Would you mind taking over this review :)

[xFrednet]

BTW, one thing you might also want to check, is if this is in a const block. I would guess that x != <float>::NEG_INFINITY works in const, while still unstable in const :)

[blyxyas]

Yeah, I will take over and control this review. Subjugate it

[Centri3]

BTW, one thing you might also want to check, is if this is in a const block. I would guess that x != <float>::NEG_INFINITY works in const, while still unstable in const :)

Good point, we can probably check that and make sure const_float_classify is not enabled

[blyxyas]

Looks good to me, thanks! ❤️
cc @xFrednet

[xFrednet]

This looks good to me, just two small nits and then it's ready for bors. Thank you for the implementation!

And thank you @blyxyas for the review :D

[xFrednet]

You can r=blyxyas,xFrednet after the update :)

Lord bors, I hereby allow queen @Centri3 to merge this PR into the master kingdom, in the name of princess @blyxyas and me ^^

[bors]

✌️ @Centri3, you can now approve this pull request!

If @xFrednet told you to "r=me" after making some further change, please make that change, then do @bors r=@xFrednet

[Centri3]

@bors r=blyxyas,xFrednet

[bors]

📌 Commit 41438c2 has been approved by blyxyas,xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 41438c2 with merge 8e261c0...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas,xFrednet
Pushing 8e261c0 to master...