[read_line_without_trim]: detect string literal comparison and .ends_with() calls

[y21]

This lint now also realizes that a comparison like s == "foo" and calls such as s.ends_with("foo") will fail if s was initialized by a call to Stdin::read_line (because of the trailing newline).

changelog: [read_line_without_trim]: detect string literal comparison and .ends_with() calls

r? @giraffate assigning you because you reviewed #10970 that added this lint, so this is kinda a followup PR ^^

[bors]

☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts.

[dswij]

r? @dswij

[y21]

wow, this PR is ancient :D

(The first commit is the actual relevant addition, the second one moves some things around which causes the diff to look a bit annoying, so it's probably better reviewed commit-by-commit)

[bors]

☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

[dswij]

Thanks for this! Sorry that the review take awhile.

Can you help to rebase this? I think it's good to merge afterward.

[dswij]

@bors r+

[bors]

📌 Commit fd85db3 has been approved by dswij

It is now in the queue for this repository.

[bors]

⌛ Testing commit fd85db3 with merge fb06081...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing fb06081 to master...