add configuration for [wildcard_imports] to ignore certain imports#11979
add configuration for [wildcard_imports] to ignore certain imports#11979bors merged 3 commits intorust-lang:masterfrom
wildcard_imports] to ignore certain imports#11979Conversation
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
J-ZhengLi
force-pushed
the
issue11428
branch
from
61f5cfd to
045b411
Compare
|
☔ The latest upstream changes (presumably #10283) made this pull request unmergeable. Please resolve the merge conflicts. |
J-ZhengLi
force-pushed
the
issue11428
branch
2 times, most recently
from
1c8ab10 to
a7c4f15
Compare
|
@Alexendoo Sorry I didn't know this has been reviewed, must've been buried under other notifications... Could you help reviewing it again? |
|
☔ The latest upstream changes (presumably #12144) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -1 +1,2 @@ | |||
| warn-on-all-wildcard-imports = true | |||
| ignored-wildcard-imports = ["utils"] | |||
There was a problem hiding this comment.
One last thing actually, would be good to add a comment here that mentions it's ignored because of warn-on-all-wildcard-imports
|
Thanks, LGTM just needs a rebase to fix the conflict |
|
Great, thanks! @bors r+ |
add configuration for [`wildcard_imports`] to ignore certain imports fixes: #11428 changelog: add configuration `ignored-wildcard-imports` for lint [`wildcard_imports`]
|
💔 Test failed - checks-action_test |
|
Ah it needs |
oh no I always forget that, oops... Should be good for now, sorry about that |
|
No worries! I think we all forget about that @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
4 participants
fixes: #11428
changelog: add configuration
ignored-wildcard-importsfor lint [wildcard_imports]