Remove dead_code paths

[CBSpeir]

The following paths are dead_code and can be removed:

clippy_utils::paths::VEC_RESIZE

• Introduced when vec_resize_to_zero lint added in PR new lint: vec_resize_to_zero #5637
• No longer used after commit 8acc4d2

clippy_utils::paths::SLICE_GET

• Introduced when get_first lint added in PR feat(lint): impl lint about use first() instead of get(0) #8882
• No longer used after commit a8d80d5

clippy_utils::paths::STR_BYTES

• Introduced when bytes_count_to_len lint added in PR Take over: New lint bytes count to len #8711
• No longer used after commit ba6a459

When the lints were moved into the Methods lint pass, they switched from using paths to diagnostic items. However, the paths were never removed. This occurred in PR #8957.

This relates to issue #5393

changelog: none

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[y21]

Makes sense. A bit unfortunate that dead_code can't emit a warning here. Do you know if there are more unused paths or is this the only one?

[CBSpeir]

I've been matching up the paths to the lints/code that use them. I made it through about half before I found VEC_RESIZE. I will continue checking the rest, and report back if I find any more dead_code.

If I find additional ones, should I add them as commits to this PR or create a new PR?

[y21]

Yeah, you can just add them here to this PR.

[CBSpeir]

In addition to VEC_RESIZE, both SLICE_GET and STR_BYTES were dead_code paths. I update the top comment to reflect this.

[y21]

Looks good. Thank you for taking the time to go through these!

@bors r+

[bors]

📌 Commit 5e05821 has been approved by y21

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5e05821 with merge c369183...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing c369183 to master...