Expand unnecessary_literal_bound to literal arrays and slices#13655
Closed
GnomedDev wants to merge 2 commits intorust-lang:masterfrom
Closed
Expand unnecessary_literal_bound to literal arrays and slices#13655GnomedDev wants to merge 2 commits intorust-lang:masterfrom
GnomedDev wants to merge 2 commits intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
Contributor
|
@GnomedDev is this still a draft now that #13557 is merged? |
Contributor
Author
|
@Jarcho that PR is not merged? |
Contributor
|
Sorry, almost merged. Is it just waiting on that? |
Contributor
Author
|
I would have agreed with "almost merged" a month ago, but it looks like it will be lost to the sands of time now. Anyway, yes it just waiting on that, then some PR review. |
Contributor
|
Feel free to ping the reviewer in cases like that (I just did it in that PR). Notifications don't do a good job of notifying when something is pushed to the PR. |
Contributor
|
☔ The latest upstream changes (presumably f83a227) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
S-waiting-on-author
Contributor
|
Closing since #13557 was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as based on #13557.
changelog: [
unnecessary_literal_bound] Now lints for returning statically promoted arrays and slices, not just literal strings