Open
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
wowinter13
changed the title
unnecessary_reserve
samueltardieu
requested changes
Jan 30, 2025
Contributor
Author
|
@samueltardieu Samuel, really appreciate your review and points! |
Member
samueltardieu
left a comment
samueltardieu
left a comment
There was a problem hiding this comment.
Could you include a test (maybe I've missed it) where extend() happens before reserve(), to make sure the lint doesn't trigger?
|
|
||
| // do not lint | ||
| vec.reserve(1); | ||
| vec.extend([1]); |
Member
There was a problem hiding this comment.
Btw, error markers are now required in order for tests to pass. If you rebase over master, you will see examples in all the UI test files.
Member
|
Also, is there any reason why this lint is not under the |
wowinter13
force-pushed
the
new-lint-unnecessary-reserve
branch
from
0bf67e5 to
37dfd0a
Compare
Collaborator
|
☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
S-waiting-on-author
Contributor
|
r? samueltardieu @wowinter13 do you plan to continue working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resurrection of #10157
fixes #8982
changelog: [
unnecessary_reserve]: add new lint unnecessary_reserve