Skip to content

Comments

Remove unused allowed unused attributes#5740

Merged
bors merged 1 commit intorust-lang:masterfrom
tesuji:unused-unused
Jun 23, 2020
Merged

Remove unused allowed unused attributes#5740
bors merged 1 commit intorust-lang:masterfrom
tesuji:unused-unused

Conversation

@tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 23, 2020

changelog: none

@rust-highfive
Copy link

rust-highfive commented Jun 23, 2020

r? @yaahc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 23, 2020
@tesuji tesuji changed the title Remove unused allowed unused attribute Remove unused allowed unused attributes Jun 23, 2020
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jun 23, 2020

Have you checked that these don't cause warnings when bootstrapping from the rustc repo?

@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2020 •
edited
Loading

I haven't. Let me build with x.py real quick.

@bors
Copy link
Contributor

bors commented Jun 23, 2020

☔ The latest upstream changes (presumably #5741) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2020 •
edited
Loading

Built locally successfully with command: ./x.py test --stage=1 src/tools/clippy.

@flip1995
Copy link
Member

flip1995 commented Jun 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 41ba4ea has been approved by flip1995

tesuji
tesuji commented Jun 23, 2020
View reviewed changes
@flip1995
Copy link
Member

flip1995 commented Jun 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 94e5394 has been approved by flip1995

@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2020

Oops. I should had have to check the doc tests. Hope it be Okay now!

@flip1995
Copy link
Member

flip1995 commented Jun 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 7374185 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 23, 2020

⌛ Testing commit 7374185 with merge c2c07fa...

@bors
Copy link
Contributor

bors commented Jun 23, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing c2c07fa to master...

@bors bors merged commit c2c07fa into rust-lang:master Jun 23, 2020
@tesuji tesuji deleted the unused-unused branch June 23, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yaahc yaahc

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tesuji @rust-highfive @matthiaskrgr @bors @flip1995 @yaahc