Rename two lints to comply with our lint naming convention#7504
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 29, 2021
Merged
Rename two lints to comply with our lint naming convention#7504bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
Those new names were discussed and agreed upon on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Misnamed.20lint.20.60append_instead_of_extend.60/near/247352538 So merging myself @bors r+ |
Contributor
|
📌 Commit 54e5391 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain
We don't need to
register_renamedthose lints, since I'll backport them to beta, so the old names won't hit stable.changelog: none
(I'll adapt the changelog before merging #7498)