Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary line in example #129

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

Victor-Savu
Copy link
Contributor

The pattern leveraging local variable shadowing has an unnecessary line (probably copy-pasta error from the previous example) and is missing a closing brace.

The pattern leveraging local variable shadowing has an unnecessary line (probably copy-pasta error from the previous example) and is missing a closing brace.
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm in the position to merge this, but here, take my approval 👍

@blyxyas
Copy link
Member

blyxyas commented Aug 18, 2024

@nikomatsakis Are we really allowed to merge minor changes like these, or do you want to take care of it 🍰

@nikomatsakis
Copy link
Contributor

I'm fine with minor changes to the goal document you own.

@nikomatsakis nikomatsakis merged commit b183738 into rust-lang:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants