Symbols: do not write string values of preinterned symbols into compiled artifacts

[klensy]

r? @bjorn3

Followup for #98851

#98851 (comment)

[bjorn3]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit f632948 with merge 423e05459f010d46d562ac19bc28630bddef001d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 423e05459f010d46d562ac19bc28630bddef001d (423e05459f010d46d562ac19bc28630bddef001d)

[rust-timer]

Queued 423e05459f010d46d562ac19bc28630bddef001d with parent dd01122, future comparison URL.

[rust-timer]

Finished benchmarking commit (423e05459f010d46d562ac19bc28630bddef001d): comparison url.

Instruction count

• Primary benchmarks: ✅ relevant improvements found
• Secondary benchmarks: ✅ relevant improvements found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	-2.6%	26
Improvements ✅ (secondary)	-1.5%	-2.5%	26
All ❌✅ (primary)	-0.7%	-2.6%	26

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	2.4%	2.4%	2
Regressions ❌ (secondary)	4.2%	6.8%	2
Improvements ✅ (primary)	-2.7%	-2.7%	1
Improvements ✅ (secondary)	-2.0%	-2.9%	5
All ❌✅ (primary)	0.7%	-2.7%	3

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	2.1%	2.1%	1
Regressions ❌ (secondary)	4.7%	4.7%	1
Improvements ✅ (primary)	-2.7%	-3.5%	4
Improvements ✅ (secondary)	-3.1%	-3.8%	14
All ❌✅ (primary)	-1.7%	-3.5%	5

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[bjorn3]

@bors r+ rollup=never

[bors]

📌 Commit f632948 has been approved by bjorn3

It is now in the queue for this repository.

[pnkfelix]

This PR addresses a performance regression injected by #98851, so I'm going to up its priority to ensure it gets in well before the aforementioned regression can cause too many problems.

@bors p=3

[matthiaskrgr]

moving before the rollup @bors p=20

[bors]

⌛ Testing commit f632948 with merge ebfc7aa...

[bors]

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing ebfc7aa to master...

[rust-timer]

Finished benchmarking commit (ebfc7aa): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-2.5%, -0.2%]	35
Improvements ✅ (secondary)	-1.7%	[-2.6%, -0.3%]	24
All ❌✅ (primary)	-0.6%	[-2.5%, -0.2%]	35

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	2
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.6%	[2.1%, 3.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	2.6%	[2.1%, 3.0%]	2

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³