Merged
Conversation
This reverts commit 9decfff.
This reverts commit a884a9e.
This reverts commit cbe9328.
https://users.rust-lang.org/t/is-the-document-in-sortedmap-in-rustc-data-structures-sorted-map-correct/84939 SortedMap have `O(n)` insertions and removal rather than `O(log(n))`
It's not obvious why this was ever a separate class name, since even in c4219a4 when it was first added, it was styled identically to regular `fn` links.
Adds a helper method around `generator_kind` that makes matching async constructs simpler.
…docs, r=tmandry Document more settings for building rustc for Fuchsia This documents that you need to link for Fuchsia with `lld` and provides configuration settings for both `clang` and `lld`. It also adjusts the documentation for running the test suite to recommend installing to a prefix. r? ``@tmandry``
…rors Simplify checking for `GeneratorKind::Async` Adds a helper method around `generator_kind` that makes matching async constructs simpler.
Revert rust-lang#104269 (to avoid spurious hang/test failure in CI) Causes hangs/memory overflows in the test suite apparently 😢 Reopens rust-lang#104225 Fixes rust-lang#104957 r? ``@lcnr``
notify the rust-analyzer team on changes to the rust-analyzer subtree As proposed in rust-lang/rust-analyzer#13676 (comment)
Fix documentation of asymptotic complexity for rustc_data_structures::SortedMap https://users.rust-lang.org/t/is-the-document-in-sortedmap-in-rustc-data-structures-sorted-map-correct/84939 SortedMap have `O(n)` insertions and removal rather than `O(log(n))`
…oc, r=notriddle Add sentence when rustdoc search is running This is a small improvement, mostly relevant on big search indexes. As soon as the search starts, it'll display:  cc ``@jsha`` r? ``@notriddle``
…, r=GuillaumeGomez rustdoc: merge background-image rules in rustdoc-toggle CSS
rustdoc: remove `fnname` CSS class that's styled exactly like `fn` It's not obvious why this was ever a separate class name, since even in c4219a4 when it was first added, it was styled identically to regular `fn` links.
…test, r=GuillaumeGomez Rustdoc-Json: Add tests for linking to foreign variants. I initially taught these would be bugs, but it turn out they work perfectly, and the variant is added to paths. Most of the work is done by jsondoclint checking all the ID's resolve (although this wont happen for links until rust-lang#105015, which in turn is blocked on removing foreign traits), but we do check that neither the enum nor the variant is inlined, so it must be resolved correctly through paths. r? ``@GuillaumeGomez``
…mpiler-errors Clean up pr 104954 UI test filename typo fix and a simple comment rewording. Thanks. CC `@vincenzopalazzo` (you spelled your name wrongly in the FIXME) r? `@estebank`
Member
Author
|
@bors r+ rollup=never p=10 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 1ef685ea39 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
arianxplore
reviewed
Nov 29, 2022
| "you may want to use a bool value instead", | ||
| format!("{}", item_typo), | ||
| )) | ||
| // FIXME(vicnenzopalazzo): make the check smarter, |
Collaborator
|
Finished benchmarking commit (0c6b88d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
GeneratorKind::Async#104951 (Simplify checking forGeneratorKind::Async)predicate_can_apply#104269 (to avoid spurious hang/test failure in CI))fnnameCSS class that's styled exactly likefn#105024 (rustdoc: removefnnameCSS class that's styled exactly likefn)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup