Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
|
|
Some changes occurred in src/tools/cargo cc @ehuss |
albertlarsan68
left a comment
There was a problem hiding this comment.
r=me on the bootstrap changes
|
Thanks! I think the lines at Lines 1088 to 1093 in fc8a3e3 |
since they are now built-in to the Cargo binary
|
Thanks! @bors r+ p=1 |
|
cc @weihanglo Just verifying you saw this. |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (864bdf7): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.189s -> 651.472s (0.04%) |
rust-lang/cargo#12369 fixed this bug and was picked up in rust-lang/rust#114027.
rust-lang/cargo#12369 fixed this bug and was picked up in rust-lang/rust#114027.
8 commits in 1b15556767f4b78a64e868eedf4073c423f02b93..7ac9416d82cd4fc5e707c9ec3574d22dff6466e5
2023-07-18 14:44:47 +0000 to 2023-07-24 14:29:38 +0000
serde/derive(fix(cargo-credential): should enable featureserde/derivecargo#12396)~/.cargo/{git,registry}(fix: only skip mtime check on~/.cargo/{git,registry}cargo#12369)Since rust-lang/cargo#12334 makes built-in credential providers part of the cargo binary, it's no longer needed to build them in bootstrap.