[beta] rustdoc ui: adjust tooltip z-index to be above sidebar#119743
Merged
bors merged 2 commits intorust-lang:betafrom Jan 11, 2024
Merged
[beta] rustdoc ui: adjust tooltip z-index to be above sidebar#119743bors merged 2 commits intorust-lang:betafrom
bors merged 2 commits intorust-lang:betafrom
Conversation
added 2 commits
January 8, 2024 14:15
and calculate the z-indices of things that go over the sidebar
Collaborator
|
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
Collaborator
|
Some changes occurred in GUI tests. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
notriddle
approved these changes
Jan 8, 2024
Contributor
notriddle
left a comment
There was a problem hiding this comment.
This seems fine to me. Should I r+ it, or should someone on the release team do that?
Member
|
@bors r=notriddle rollup=never |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119477.
Fixes #119472.
range-diff:
The "show sidebar" button on the source view page works differently on beta and nightly, but it is in fact above the sidebar in both versions.
beta button:

nightly button:

cc @Mark-Simulacrum