Expose the `Freeze` trait again (unstably) and forbid implementing it manually by oli-obk · Pull Request #121501 · rust-lang/rust

oli-obk · 2024-02-23T12:12:11Z

This trait is useful for generic constants (associated consts of generic traits). See the test (tests/ui/associated-consts/freeze.rs) added in this PR for a usage example. The builtin Freeze trait is the only way to do it, users cannot work around this issue.

It's also a useful trait for building some very specific abstrations, as shown by the usage by the zerocopy crate: google/zerocopy#941

cc @RalfJung

r? libs-api

Open questions

naming: Could also have a name that contains Cell, as the trait signals the absence of UnsafeCell.

compiler/rustc_feature/src/unstable.rs

oli-obk · 2024-02-23T16:09:38Z

I broke github :( I already pushed to this branch, but it hasn't updated in two hours

compiler/rustc_hir_analysis/src/coherence/mod.rs

rustbot · 2024-02-23T16:26:45Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

In `auxiliary/sigpipe-utils.rs`, all we want to know is the current `SIGPIPE` disposition. We should not change it. So use `libc::sigaction` instead of `libc::signal`. That way we can also remove the code that restores it.

This allows for Windows users to use miri-script without pain

Windows miri-script execution egronomics This allows for Windows users to use miri-script without pain. As working on miri earlier I was doing `.\miri-script\target\debug\miri-script.exe { install | build | ... }` which wasn't fun.

Add "cargo miri clean" command My first reaction when my miri cache was messed up was to attempt run this, which obviously failed. This helps paper over platform differences and such.

compiler: clippy::complexity fixes

compiletest: call cargo-miri directly rather than via 'cargo run' Fixes rust-lang/miri#3297. Thanks to `@bjorn3` for figuring out the cause of this. r? `@oli-obk`

Co-authored-by: Ben Kimock <kimockb@gmail.com>

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121435 (Account for RPITIT in E0310 explicit lifetime constraint suggestion) - rust-lang#121490 (Rustdoc: include crate name in links for local primitives) - rust-lang#121520 (delay cloning of iterator items) - rust-lang#121522 (check that simd_insert/extract indices are in-bounds) - rust-lang#121531 (Ignore less tests in debug builds) - rust-lang#121539 (compiler/rustc_target/src/spec/base/apple/tests.rs: Avoid unnecessary large move) - rust-lang#121542 (update stdarch) r? `@ghost` `@rustbot` modify labels: rollup

…slice, r=Mark-Simulacrum Add examples for some methods on slices Adds some examples to some methods on slice. `is_empty` didn't have an example for an empty slice, even though `str` and the collections all have one, so I added that in. `first_mut` and `last_mut` didn't have an example for what happens when the slice is empty, whereas `first` and `last` do, so I added that too.

…wjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? ``@matthewjasper``

…on, r=Mark-Simulacrum Ignore compiletest test directive migration commits Not sure if the corresponding bors commit need to be included as well, assuming not.

…-obk promotion: don't promote int::MIN / -1 Looks like I entirely forgot about this case when adding the div-by-zero check, which was supposed to ensure that we never promote operations that can fail... Cc rust-lang#80619 This is a breaking change, so needs a crater run. r? ``@oli-obk``

Fix incorrect doc of ScopedJoinHandle::is_finished Fixes the explanation how to use `is_finished` to achieve a non-blocking join. The updated version matches the documentation of the non-scoped JoinHandle::is_finished.

Forbid use of `extern "C-unwind"` inside standard library Those libraries are build with `-C panic=unwind` and is expected to be linkable to `-C panic=abort` library. To ensure unsoundness compiler needs to prevent a `C-unwind` call to exist, as doing so may leak foreign exceptions into `-C panic=abort`. r? ``@RalfJung``

oli-obk · 2024-02-29T13:09:16Z

wtf, sorry everyone...

rustbot · 2024-02-29T16:04:58Z

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

rustbot · 2024-02-29T16:05:02Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

oli-obk · 2024-02-29T19:04:11Z

At this point I have to assume that GitHub chokes on the emoji branch name. It takes 3h to accept a force push, and I am certain the branch is correctly based off master

lnicola · 2024-02-29T19:10:26Z

You could also try filing a new one (with fewer than 1000 commits).

oli-obk · 2024-03-01T09:32:59Z

Yea, must be the emoji 💀

I opened #121840 at the same commit as this PR, and it works just fine ™️

Expose the Freeze trait again (unstably) and forbid implementing it manually non-emoji version of rust-lang#121501 cc rust-lang#60715 This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue. It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941 cc `@RalfJung` T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)

Expose the Freeze trait again (unstably) and forbid implementing it manually non-emoji version of rust-lang#121501 cc rust-lang#60715 This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue. It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941 cc ``@RalfJung`` T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)

Expose the Freeze trait again (unstably) and forbid implementing it manually non-emoji version of rust-lang#121501 cc rust-lang#60715 This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue. It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941 cc ```@RalfJung``` T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)

Rollup merge of rust-lang#121840 - oli-obk:freeze, r=dtolnay Expose the Freeze trait again (unstably) and forbid implementing it manually non-emoji version of rust-lang#121501 cc rust-lang#60715 This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue. It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941 cc ```@RalfJung``` T-lang signed off on reexposing this unstably: rust-lang#121501 (comment)

Expose the Freeze trait again (unstably) and forbid implementing it manually non-emoji version of rust-lang/rust#121501 cc #60715 This trait is useful for generic constants (associated consts of generic traits). See the test (`tests/ui/associated-consts/freeze.rs`) added in this PR for a usage example. The builtin `Freeze` trait is the only way to do it, users cannot work around this issue. It's also a useful trait for building some very specific abstrations, as shown by the usage by the `zerocopy` crate: google/zerocopy#941 cc ```@RalfJung``` T-lang signed off on reexposing this unstably: rust-lang/rust#121501 (comment)

rustbot assigned dtolnay Feb 23, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 23, 2024

This comment has been minimized.

Sign in to view

asquared31415 reviewed Feb 23, 2024

View reviewed changes

compiler/rustc_feature/src/unstable.rs Outdated Show resolved Hide resolved

jswrenn reviewed Feb 23, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/coherence/mod.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jswrenn mentioned this pull request Feb 23, 2024

Leverage core::marker::Freeze google/zerocopy#941

Closed

This comment has been minimized.

Sign in to view

Enselic and others added 18 commits February 24, 2024 16:18

compiler: use addr_of!

613cb32

Windows miri-script execution egronomics

c7be443

This allows for Windows users to use miri-script without pain

Add "cargo miri clean" command

3e7c2e1

compiletest: call cargo-miri directly rather than via 'cargo run'

cd36cda

Auto merge of rust-lang#3312 - RossSmyth:miri-clean, r=RalfJung

4db9a36

Add "cargo miri clean" command My first reaction when my miri cache was messed up was to attempt run this, which obviously failed. This helps paper over platform differences and such.

Auto merge of rust-lang#121523 - matthiaskrgr:comp_comp, r=Nilstrieb

6bdb8a4

compiler: clippy::complexity fixes

Auto merge of rust-lang#3318 - RalfJung:compiletest-rebuilds, r=oli-obk

55dcf9c

compiletest: call cargo-miri directly rather than via 'cargo run' Fixes rust-lang/miri#3297. Thanks to `@bjorn3` for figuring out the cause of this. r? `@oli-obk`

Add #[rustc_no_mir_inline] for standard library UB checks

81d7069

Co-authored-by: Ben Kimock <kimockb@gmail.com>

Stabilize cfg_target_abi

93ec0e6

Rollup merge of rust-lang#121474 - jieyouxu:ignore-directives-migrati…

59a2cd4

…on, r=Mark-Simulacrum Ignore compiletest test directive migration commits Not sure if the corresponding bors commit need to be included as well, assuming not.

Rollup merge of rust-lang#121530 - wgslr:master, r=Mark-Simulacrum

106e30e

Fix incorrect doc of ScopedJoinHandle::is_finished Fixes the explanation how to use `is_finished` to achieve a non-blocking join. The updated version matches the documentation of the non-scoped JoinHandle::is_finished.

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

oli-obk added 2 commits February 29, 2024 13:55

Expose Freeze trait again

f030d49

Forbid implementing Freeze even if the trait is stabilized

7849230

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 29, 2024

oli-obk mentioned this pull request Mar 1, 2024

Expose the Freeze trait again (unstably) and forbid implementing it manually #121840

Merged

oli-obk closed this Mar 1, 2024

kpreid mentioned this pull request May 17, 2024

core::marker::NoCell in bounds (previously known an Freeze) rust-lang/rfcs#3633

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose the `Freeze` trait again (unstably) and forbid implementing it manually#121501

Hidden character warning

Expose the `Freeze` trait again (unstably) and forbid implementing it manually#121501
oli-obk wants to merge 652 commits intorust-lang:masterfrom
oli-obk:🥶

oli-obk commented Feb 23, 2024 •

edited by RalfJung

Loading

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Feb 23, 2024

Uh oh!

Uh oh!

rustbot commented Feb 23, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

oli-obk commented Feb 29, 2024 •

edited

Loading

Uh oh!

This comment has been minimized.

rustbot commented Feb 29, 2024

Uh oh!

rustbot commented Feb 29, 2024

Uh oh!

oli-obk commented Feb 29, 2024

Uh oh!

lnicola commented Feb 29, 2024 •

edited

Loading

Uh oh!

oli-obk commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

oli-obk commented Feb 23, 2024 • edited by RalfJung Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Open questions

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Feb 23, 2024

Uh oh!

Uh oh!

rustbot commented Feb 23, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

oli-obk commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Feb 29, 2024

Uh oh!

rustbot commented Feb 29, 2024

Uh oh!

oli-obk commented Feb 29, 2024

Uh oh!

lnicola commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

oli-obk commented Feb 23, 2024 •

edited by RalfJung

Loading

oli-obk commented Feb 29, 2024 •

edited

Loading

lnicola commented Feb 29, 2024 •

edited

Loading