[beta] Revert "Disallow ambiguous attributes on expressions" on beta by lqd · Pull Request #126102 · rust-lang/rust

lqd · 2024-06-06T21:24:28Z

As discussed in today's t-compiler meeting, this reverts PR #124099 on beta to fix P-critical beta regressions #125199.

This is the revert of #124099 on beta that I mentioned in #126101, in case that's what you also wanted. Opening as draft in case it's not.

I'm not well-versed in these backports, so I hope I did it right 😓

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

rustbot · 2024-06-06T21:24:37Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

wesleywiser · 2024-06-06T22:32:52Z

The revert looks correct to me so:

@bors r+

bors · 2024-06-06T22:32:55Z

📌 Commit b2be3bb has been approved by wesleywiser

It is now in the queue for this repository.

rustbot · 2024-06-06T22:33:04Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

wesleywiser · 2024-06-06T22:33:44Z

@bors p=1

Beta backport

[beta] Revert "Disallow ambiguous attributes on expressions" on beta As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 on beta to fix P-critical beta regressions rust-lang#125199. r? `@wesleywiser` This is the revert of rust-lang#124099 on beta that I mentioned in rust-lang#126101, in case that's what you also wanted. Opening as draft in case it's not. I'm not well-versed in these backports, so I hope I did it right 😓

bors · 2024-06-07T00:50:26Z

⌛ Testing commit b2be3bb with merge ce99170...

rust-log-analyzer · 2024-06-07T01:02:03Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#13 DONE 52.7s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.098 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.108 Executing: /tmp/apt-key-gpghome.ZSOyaBwhzh/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.482 gpg: Total number processed: 1
#14 0.482 gpg:               imported: 1
#14 DONE 0.6s

bors · 2024-06-07T01:02:29Z

💔 Test failed - checks-actions

lqd · 2024-06-07T01:08:19Z

ERROR: failed to solve: process "/bin/sh -c /tmp/build-solaris-toolchain.sh x86_64 amd64 solaris-i386 pc" did not complete successfully: exit code: 1

no way, beta CI is borked and we may need to backport #126011

the other beta backport also failed because of this

workingjubilee · 2024-06-07T01:18:54Z

This will be landing with #126093

[beta] backports - Fix insufficient logic when searching for the underlying allocation rust-lang#124761 - Handle field projections like slice indexing in invalid_reference_casting rust-lang#124908 - Handle Deref expressions in invalid_reference_casting rust-lang#124978 - Fix ICE in non-operand `aggregate_raw_ptr` instrinsic codegen rust-lang#125184 - Wrap Context.ext in AssertUnwindSafe rust-lang#125392 - Revert problematic opaque type change rust-lang#125489 - ast: Revert a breaking attribute visiting order change rust-lang#125734 - Update to LLVM 18.1.7 rust-lang#126061 - Revert "Disallow ambiguous attributes on expressions" on beta rust-lang#126102 / rust-lang#126101 - Silence double-symlink errors while building solaris toolchain rust-lang#126011 r? cuviper

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? `@wesleywiser` Opening as draft so that `@wesleywiser` and `@apiraino,` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

Rollup merge of rust-lang#126101 - lqd:revert-124099, r=wesleywiser Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

[beta] backports - Fix insufficient logic when searching for the underlying allocation rust-lang#124761 - Handle field projections like slice indexing in invalid_reference_casting rust-lang#124908 - Handle Deref expressions in invalid_reference_casting rust-lang#124978 - Fix ICE in non-operand `aggregate_raw_ptr` instrinsic codegen rust-lang#125184 - Wrap Context.ext in AssertUnwindSafe rust-lang#125392 - Revert problematic opaque type change rust-lang#125489 - ast: Revert a breaking attribute visiting order change rust-lang#125734 - Update to LLVM 18.1.7 rust-lang#126061 - Revert "Disallow ambiguous attributes on expressions" on beta rust-lang#126102 / rust-lang#126101 - Silence double-symlink errors while building solaris toolchain rust-lang#126011 r? cuviper

Revert "Disallow ambiguous attributes on expressions" on nightly As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199. r? ``@wesleywiser`` Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted: 1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those) 2. a revert of rust-lang#124099 on beta? 3. all of the above? I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.

Revert "Rollup merge of rust-lang#124099 - voidc:disallow-ambiguous-e…

b2be3bb

…xpr-attrs, r=davidtwco" This reverts commit 57dad1d, reversing changes made to 36316df.

rustbot assigned wesleywiser Jun 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2024

lqd mentioned this pull request Jun 6, 2024

Revert "Disallow ambiguous attributes on expressions" on nightly #126101

Merged

wesleywiser approved these changes Jun 6, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2024

wesleywiser marked this pull request as ready for review June 6, 2024 22:33

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2024

lqd mentioned this pull request Jun 7, 2024

[beta] backports #126093

Merged

workingjubilee closed this Jun 7, 2024

lqd deleted the beta-revert-124099 branch June 7, 2024 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[beta] Revert "Disallow ambiguous attributes on expressions" on beta#126102

[beta] Revert "Disallow ambiguous attributes on expressions" on beta#126102
lqd wants to merge 1 commit intorust-lang:betafrom
lqd:beta-revert-124099

lqd commented Jun 6, 2024

Uh oh!

rustbot commented Jun 6, 2024

Uh oh!

wesleywiser commented Jun 6, 2024

Uh oh!

bors commented Jun 6, 2024

Uh oh!

rustbot commented Jun 6, 2024

Uh oh!

wesleywiser commented Jun 6, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

rust-log-analyzer commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

lqd commented Jun 7, 2024

Uh oh!

workingjubilee commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

lqd commented Jun 6, 2024

Uh oh!

rustbot commented Jun 6, 2024

Uh oh!

wesleywiser commented Jun 6, 2024

Uh oh!

bors commented Jun 6, 2024

Uh oh!

rustbot commented Jun 6, 2024

Uh oh!

wesleywiser commented Jun 6, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

rust-log-analyzer commented Jun 7, 2024

Uh oh!

bors commented Jun 7, 2024

Uh oh!

lqd commented Jun 7, 2024

Uh oh!

workingjubilee commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants