use precompiled rustdoc with CI rustc#127463
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 20, 2024
Merged
Conversation
Collaborator
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
onur-ozkan
force-pushed
the
precompiled-rustdoc
branch
from
705abcf to
154574c
Compare
Kobzol
reviewed
Jul 7, 2024
onur-ozkan
force-pushed
the
precompiled-rustdoc
branch
2 times, most recently
from
474ac56 to
b11d983
Compare
Collaborator
|
☔ The latest upstream changes (presumably #127653) made this pull request unmergeable. Please resolve the merge conflicts. |
onur-ozkan
added
S-waiting-on-author
onur-ozkan
force-pushed
the
precompiled-rustdoc
branch
from
b11d983 to
0320e29
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Contributor
Author
|
Resolved the conflicts (and it was quite messy one..). @rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
Author
|
r? bootstrap (due to inactivity on the review) |
Kobzol
reviewed
Jul 20, 2024
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
It seem to work fine locally. Left two comments, but feel free to r=me.
Member
|
r? @Kobzol |
onur-ozkan
force-pushed
the
precompiled-rustdoc
branch
from
0320e29 to
0636293
Compare
When CI rustc is enabled and rustdoc sources are unchanged, we can use the precompiled rustdoc from the CI rustc's sysroot. This speeds up bootstrapping quite a lot by avoiding unnecessary rustdoc compilation. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Contributor
Author
|
@bors r=Kobzol |
Collaborator
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 20, 2024
…Kobzol use precompiled rustdoc with CI rustc When CI rustc is enabled and rustdoc sources are unchanged, we can use the precompiled rustdoc from the CI rustc's sysroot. This speeds up bootstrapping quite a lot by avoiding unnecessary rustdoc compilation.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127463 ( use precompiled rustdoc with CI rustc) - rust-lang#127779 (Add a hook for `should_codegen_locally`) - rust-lang#127843 (unix: document unsafety for std `sig{action,altstack}`) - rust-lang#127873 (kmc-solid: `#![forbid(unsafe_op_in_unsafe_fn)]`) - rust-lang#127917 (match lowering: Split `finalize_or_candidate` into more coherent methods) - rust-lang#127964 (run_make_support: skip rustfmt for lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2024
Rollup merge of rust-lang#127463 - onur-ozkan:precompiled-rustdoc, r=Kobzol use precompiled rustdoc with CI rustc When CI rustc is enabled and rustdoc sources are unchanged, we can use the precompiled rustdoc from the CI rustc's sysroot. This speeds up bootstrapping quite a lot by avoiding unnecessary rustdoc compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CI rustc is enabled and rustdoc sources are unchanged, we can use the precompiled rustdoc from the CI rustc's sysroot. This speeds up bootstrapping quite a lot by avoiding unnecessary rustdoc compilation.