Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake by Oneirical · Pull Request #127523 · rust-lang/rust

Oneirical · 2024-07-09T15:57:36Z

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: x86_64-msvc
try-job: i686-mingw

rustbot · 2024-07-09T15:57:45Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-09T15:57:47Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-09T16:41:42Z

@bors delegate+ (for try jobs only)

bors · 2024-07-09T16:41:46Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu · 2024-07-09T16:41:46Z

@bors try

bors · 2024-07-09T16:42:56Z

⌛ Trying commit 7b37e2b with merge 56e4ec0...

Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: aarch64-apple try-job: x86_64-msvc

bors · 2024-07-09T18:20:39Z

💔 Test failed - checks-actions

Oneirical · 2024-07-09T18:45:39Z

Very strange... that was supposed to have been fixed by #116814. Let's try it without the assertion and with some debug logging. At least, apple does pass!
@bors try

Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc

bors · 2024-07-09T18:46:50Z

⌛ Trying commit fb0e011 with merge 9cd4712...

bors · 2024-07-09T20:19:25Z

☀️ Try build successful - checks-actions
Build commit: 9cd4712 (9cd4712a81071a234459c596d88179e84562cc97)

Oneirical · 2024-07-09T20:54:44Z

Very well, I am removing that check for colons (:) in Windows filenames. Tell me if that is unwise.
@rustbot review

jieyouxu

Thank you for the PR. I have some concerns about dump-ice-to-disk regarding test parity and a question about a FIXME in panic_abort-eh_frame.

tests/run-make/panic-abort-eh_frame/rmake.rs

tests/run-make/dump-ice-to-disk/rmake.rs

tests/run-make/dump-ice-to-disk/check.sh

tests/run-make/dump-ice-to-disk/rmake.rs

jieyouxu · 2024-07-12T06:38:57Z

@rustbot author

bors · 2024-07-20T05:58:45Z

💔 Test failed - checks-actions

tgross35 · 2024-07-20T10:28:47Z

Ah I didn't r- fast enough, this failed the rollup too #127991 (comment). Almost all tests except i686-mingw passed, updated the try jobs.

bors · 2024-07-20T22:22:01Z

☔ The latest upstream changes (presumably #127663) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-22T15:24:09Z

I restored the ignore on this specific platform, let me know if that is adequate.

jieyouxu

Thank you, the other changes look good, but the ignore on the panic-abort test is a bit interesting, I'll wait for people who are more familiar to see if it's intentional that it fails on i686-pc-windows-gnu.

jieyouxu · 2024-07-22T17:19:45Z

tests/run-make/panic-abort-eh_frame/rmake.rs

+//@ ignore-i686-pc-windows-gnu
+// Reason: the DW_CFA symbol appears on this specific architecture


Question: cc @Nilstrieb (since you were the reviewer of #112403) and @saethlin, since I lack context for this test: is it intentional that this property is only preserved for linux, but not necessarily for i686-pc-windows-gnu, or is this a bug? The original test was only-linux but I couldn't find reasons for why it had to be only-linux other than it was impacting RfL so obviously we would want to test it on linux.

The context is that everything under -Zub-checks creates non-unwinding panics, so it is a problem for RFL and quite goofy in general if enabling -Zub-checks produces new sections which are only for unwinding.

I don't know enough about this target to say whether it has this section with UB checks disabled. If it has this section with UB checks off that seems like a separate bug, we can handle that in another issue. If it gains this section when UB checks are enabled on this target specifically I would really like to know why.

Actually this is intended behavior that uwtable is forced on Windows (cf. #128136 (comment)), see

rust/compiler/rustc_target/src/spec/base/windows_msvc.rs

Line 19 in d24930c

requires_uwtable: true,

Can you revert this to //@ only-linux and add a comment to that effect?

Sounds good to me!

bors · 2024-07-23T22:13:44Z

☔ The latest upstream changes (presumably #128109) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu

Thanks, r=me after a rebase + adding the FIXME linking to #128136.

jieyouxu · 2024-07-24T12:16:53Z

tests/run-make/panic-abort-eh_frame/rmake.rs

+//@ ignore-i686-pc-windows-gnu
+// Reason: the DW_CFA symbol appears on this specific architecture


Actually this is intended behavior that uwtable is forced on Windows (cf. #128136 (comment)), see

rust/compiler/rustc_target/src/spec/base/windows_msvc.rs

Line 19 in d24930c

requires_uwtable: true,

Can you revert this to //@ only-linux and add a comment to that effect?

Oneirical · 2024-07-24T13:55:27Z

Thanks, r=me after a rebase + adding the FIXME linking to #128136.

There's something weird about this. The uwtable forcing file is named windows_msvc.rs, and the test does pass on MSVC (see https://github.com/rust-lang-ci/rust/actions/runs/10017286801/job/27691281649, it's not even getting ignored). It even passes on x86 gnu-windows. It is only this one specific architecture (i686-mingw) that fails.

Given this, why would only-linux be superior to the current ignore?

jieyouxu · 2024-07-25T11:25:21Z

Let's keep it only-linux and just document that currently uwtables are forced on windows targers (apparently they're eventually forced even on windows-gnu). AFAICT we only are trying to guarantee this property on linux, but not for Windows.

Oneirical · 2024-07-25T15:17:46Z

@bors r=@jieyouxu

bors · 2024-07-25T15:17:48Z

📌 Commit f72bf8b has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#126575 (Make it crystal clear what lint `type_alias_bounds` actually signifies) - rust-lang#127017 (Extend rules of dead code analysis for impls for adts to impls for types refer to adts) - rust-lang#127523 (Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake) - rust-lang#127557 (Add a label to point to the lacking macro name definition) - rust-lang#127989 (Migrate `interdependent-c-libraries`, `compiler-rt-works-on-mingw` and `incr-foreign-head-span` `run-make` tests to rmake) - rust-lang#128099 (migrate tests/run-make/extern-flag-disambiguates to rmake) - rust-lang#128170 (Make Clone::clone a lang item) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-07-26T10:49:55Z

⌛ Testing commit f72bf8b with merge 83d6768...

Rollup merge of rust-lang#127523 - Oneirical:treasure-test, r=jieyouxu Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw

tgross35 · 2024-07-26T10:52:40Z

🤔 bors you tested it already

rustbot assigned jieyouxu Jul 9, 2024

Kobzol mentioned this pull request Jul 9, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024

Oneirical force-pushed the treasure-test branch from 7b37e2b to fb0e011 Compare July 9, 2024 18:44

Oneirical force-pushed the treasure-test branch from fb0e011 to eb20836 Compare July 9, 2024 20:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024

jieyouxu reviewed Jul 12, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2024

Oneirical force-pushed the treasure-test branch 2 times, most recently from e7cfc85 to 184649c Compare July 22, 2024 15:23

jieyouxu approved these changes Jul 22, 2024

View reviewed changes

jieyouxu mentioned this pull request Jul 24, 2024

.eh_frame is emitted for -C panic=abort on (at least) i686-pc-windows-gnu #128136

Closed

jieyouxu approved these changes Jul 24, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Oneirical force-pushed the treasure-test branch from 184649c to cd41fa1 Compare July 25, 2024 15:17

Oneirical added 2 commits July 25, 2024 11:17

rewrite dump-ice-to-disk to rmake

0d52289

rewrite panic-abort-eh_frame to rmake

f72bf8b

Oneirical force-pushed the treasure-test branch from cd41fa1 to f72bf8b Compare July 25, 2024 15:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2024

tgross35 mentioned this pull request Jul 26, 2024

Rollup of 7 pull requests #128222

Merged

bors merged commit 96fb354 into rust-lang:master Jul 26, 2024

rustbot added this to the 1.82.0 milestone Jul 26, 2024

		//@ ignore-i686-pc-windows-gnu
		// Reason: the DW_CFA symbol appears on this specific architecture

Uh oh!

Conversation

Oneirical commented Jul 9, 2024 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 9, 2024

Uh oh!

rustbot commented Jul 9, 2024

Uh oh!

jieyouxu commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

jieyouxu commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 9, 2024

Uh oh!

Oneirical commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

Oneirical commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 12, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

tgross35 commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 20, 2024

Uh oh!

Oneirical commented Jul 22, 2024

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

saethlin Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saethlin Jul 24, 2024

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 23, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Oneirical commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Oneirical commented Jul 9, 2024 •

edited by tgross35

Loading

Oneirical commented Jul 9, 2024 •

edited

Loading

tgross35 commented Jul 20, 2024 •

edited

Loading

jieyouxu left a comment •

edited

Loading

saethlin Jul 22, 2024 •

edited

Loading

jieyouxu Jul 24, 2024 •

edited

Loading

jieyouxu Jul 24, 2024 •

edited

Loading

Oneirical commented Jul 24, 2024 •

edited

Loading

jieyouxu commented Jul 25, 2024 •

edited

Loading