Handle `rustc_middle` cases of `rustc::potential_query_instability` lint by ismailarilik · Pull Request #131160 · rust-lang/rust

ismailarilik · 2024-10-02T16:16:02Z

This PR removes #![allow(rustc::potential_query_instability)] line from compiler/rustc_middle/src/lib.rs and converts FxHash{Map,Set} types into FxIndex{Map,Set} to suppress lint errors.

A somewhat tracking issue: #84447

r? @compiler-errors

rustbot · 2024-10-02T16:16:10Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2024-10-02T16:16:13Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

bors · 2024-10-10T18:45:22Z

☔ The latest upstream changes (presumably #131263) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-11-12T18:42:29Z

☔ The latest upstream changes (presumably #132282) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2025-01-23T18:06:00Z

I'm gonna re-roll this so this PR gets more attention, sorry for my inactivity.

r? compiler

But also reassigning to author sicne I think this PR still needs updating.

@rustbot author

SparrowLii · 2025-01-26T00:47:13Z

@ismailarilik Can you rebase the PR today? I'm in holiday tomorrow so I"d like to have a review before that :)

SparrowLii · 2025-01-26T07:07:52Z

r? compiler cause I'm going to the holidays in the next few days.

And I suggest to run a rustc perf when it's ready since this PR change the cache struct

Dylan-DPC · 2025-02-25T18:51:25Z

@ismailarilik any updates on this? thanks

ismailarilik · 2025-02-26T05:36:41Z

@ismailarilik any updates on this? thanks

Sorry, I missed the previous comment. I've just fixed conflicts. But since I have no access to the git tool in a machine nowadays, I had to do it using the web UI so there is a merge commit now. I can fix it later or feel free to fix.

bors · 2025-03-02T02:02:32Z

☔ The latest upstream changes (presumably #137752) made this pull request unmergeable. Please resolve the merge conflicts.

ismailarilik · 2025-03-03T07:24:07Z

Could you update the outputs and then rebase? Nowadays I don't have access neither Git nor Rust. 2 Mar 2025 Paz 08:23 tarihinde Rust Log Analyzer ***@***.***> şunu yazdı:

…

The job *x86_64-gnu-tools* failed! Check out the build log: (web) <https://github.com/rust-lang/rust/actions/runs/13612225803/job/38050862251> (plain) <https://github.com/rust-lang/rust/commit/b2dd7bd0d15f098c8d112c4e881a47dd489234cb/checks/38050862251/logs> *Click to see the possible cause of the failure (guessed by this bot)* +++ <fixed output> ***@***.***:2015 ... 14 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports ... 5 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::inner_extern_bar; //~^ wildcard_imports //~^ wildcard_imports -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 107 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } --- error: actual output differed from expected Execute `cargo uibless` to update `tests/ui/wildcard_imports_2021.edition2018.fixed` to the actual output --- tests/ui/wildcard_imports_2021.edition2018.fixed +++ <fixed output> ***@***.***: edition2018 edition2021 ***@***.*** edition:2018 ... 12 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports use crate::struct_mod::{A, inner_struct_mod}; //~^ wildcard_imports use wildcard_imports_helper::prelude::v1::*; use wildcard_imports_helper::prelude::v1::*; -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 104 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } --- error: actual output differed from expected Execute `cargo uibless` to update `tests/ui/wildcard_imports_2021.edition2021.fixed` to the actual output --- tests/ui/wildcard_imports_2021.edition2021.fixed +++ <fixed output> ***@***.***: edition2018 edition2021 ***@***.*** edition:2018 ... 12 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports use crate::struct_mod::{A, inner_struct_mod}; //~^ wildcard_imports use wildcard_imports_helper::prelude::v1::*; use wildcard_imports_helper::prelude::v1::*; -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 104 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } — Reply to this email directly, view it on GitHub <#131160 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEGFHYPVGPHC2QPC4PMXSBD2SKIWRAVCNFSM6AAAAABPIAPP7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGU3DIOBZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: rust-log-analyzer]*rust-log-analyzer* left a comment (rust-lang/rust#131160) <#131160 (comment)> The job *x86_64-gnu-tools* failed! Check out the build log: (web) <https://github.com/rust-lang/rust/actions/runs/13612225803/job/38050862251> (plain) <https://github.com/rust-lang/rust/commit/b2dd7bd0d15f098c8d112c4e881a47dd489234cb/checks/38050862251/logs> *Click to see the possible cause of the failure (guessed by this bot)* +++ <fixed output> ***@***.***:2015 ... 14 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports ... 5 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::inner_extern_bar; //~^ wildcard_imports //~^ wildcard_imports -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 107 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } --- error: actual output differed from expected Execute `cargo uibless` to update `tests/ui/wildcard_imports_2021.edition2018.fixed` to the actual output --- tests/ui/wildcard_imports_2021.edition2018.fixed +++ <fixed output> ***@***.***: edition2018 edition2021 ***@***.*** edition:2018 ... 12 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports use crate::struct_mod::{A, inner_struct_mod}; //~^ wildcard_imports use wildcard_imports_helper::prelude::v1::*; use wildcard_imports_helper::prelude::v1::*; -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 104 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } --- error: actual output differed from expected Execute `cargo uibless` to update `tests/ui/wildcard_imports_2021.edition2021.fixed` to the actual output --- tests/ui/wildcard_imports_2021.edition2021.fixed +++ <fixed output> ***@***.***: edition2018 edition2021 ***@***.*** edition:2018 ... 12 lines skipped ... use crate::mod_mod::inner_mod; //~^ wildcard_imports -use crate::multi_fn_mod::{multi_bar, multi_foo, multi_inner_mod}; +use crate::multi_fn_mod::{multi_foo, multi_bar, multi_inner_mod}; //~^ wildcard_imports use crate::struct_mod::{A, inner_struct_mod}; //~^ wildcard_imports use wildcard_imports_helper::prelude::v1::*; use wildcard_imports_helper::prelude::v1::*; -use wildcard_imports_helper::{ExternA, extern_foo}; +use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 104 lines skipped ... use wildcard_imports_helper::inner::inner_for_self_import::{self, inner_extern_foo}; //~^ wildcard_imports //~^ wildcard_imports - use wildcard_imports_helper::{ExternA, extern_foo}; + use wildcard_imports_helper::{extern_foo, ExternA}; //~^ wildcard_imports ... 17 lines skipped ... fn test_extern_reexported() { fn test_extern_reexported() { - use wildcard_imports_helper::{ExternExportedEnum, ExternExportedStruct, extern_exported}; + use wildcard_imports_helper::{extern_exported, ExternExportedStruct, ExternExportedEnum}; //~^ wildcard_imports ... 25 lines skipped ... fn test_reexported() { fn test_reexported() { - use crate::in_fn_test::{ExportedEnum, ExportedStruct, exported}; + use crate::in_fn_test::{exported, ExportedStruct, ExportedEnum}; //~^ wildcard_imports ... 102 lines skipped ... } } — Reply to this email directly, view it on GitHub <#131160 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEGFHYPVGPHC2QPC4PMXSBD2SKIWRAVCNFSM6AAAAABPIAPP7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGU3DIOBZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

oli-obk · 2025-05-01T15:54:39Z

@bors try @rust-timer queue

…instability-lint-for-rustc-middle, r=<try> Handle `rustc_middle` cases of `rustc::potential_query_instability` lint This PR removes `#![allow(rustc::potential_query_instability)]` line from [`compiler/rustc_middle/src/lib.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_middle/src/lib.rs#L29) and converts `FxHash{Map,Set}` types into `FxIndex{Map,Set}` to suppress lint errors. A somewhat tracking issue: rust-lang#84447 r? `@compiler-errors`

bors · 2025-05-01T15:55:53Z

⌛ Trying commit 6bf8881 with merge 9d711dc...

bors · 2025-05-01T18:02:08Z

☀️ Try build successful - checks-actions
Build commit: 9d711dc (9d711dcae3bcbeb0efda0beffb8e957488893e63)

rust-timer · 2025-05-01T19:51:39Z

Finished benchmarking commit (9d711dc): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.4%, 0.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.1%, secondary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.4%]	10
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-0.9%	[-1.9%, -0.4%]	12
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-0.1%	[-1.9%, 1.4%]	22

Cycles

Results (primary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.9%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.0%, -0.4%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.0%, 0.9%]	20

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.358s -> 769.173s (0.11%)
Artifact size: 365.48 MiB -> 365.43 MiB (-0.01%)

compiler/rustc_middle/src/ty/print/pretty.rs

oli-obk · 2025-05-05T13:52:14Z

@bors r+

bors · 2025-05-05T13:52:16Z

📌 Commit 2426dbc has been approved by oli-obk

It is now in the queue for this repository.

bors · 2025-05-06T01:36:27Z

⌛ Testing commit 2426dbc with merge 7295b08...

bors · 2025-05-06T04:45:13Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 7295b08 to master...

github-actions · 2025-05-06T04:47:33Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4a0969e (parent) -> 7295b08 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7295b08a17d1107155acd4b552069e3705b0ab1f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8260.1s -> 10045.2s (21.6%)
dist-apple-various: 6615.2s -> 7972.3s (20.5%)
x86_64-apple-2: 5720.8s -> 4724.5s (-17.4%)
x86_64-apple-1: 9360.6s -> 8044.2s (-14.1%)
dist-x86_64-illumos: 6240.1s -> 5763.6s (-7.6%)
dist-x86_64-freebsd: 4808.8s -> 5100.8s (6.1%)
dist-aarch64-linux: 5259.9s -> 5549.8s (5.5%)
x86_64-gnu-llvm-19-2: 5979.8s -> 6289.2s (5.2%)
x86_64-gnu-llvm-19-3: 6805.2s -> 7141.5s (4.9%)
dist-x86_64-mingw: 7638.6s -> 8011.9s (4.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-06T06:20:52Z

Finished benchmarking commit (7295b08): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.2%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[1.2%, 3.4%]	3
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-0.7%	[-1.4%, -0.4%]	15
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.4%, 3.4%]	18

Cycles

Results (primary -0.6%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 1.1%]	16
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-6.8%, -0.4%]	16
Improvements ✅ (secondary)	-2.2%	[-2.9%, -1.5%]	2
All ❌✅ (primary)	-0.6%	[-6.8%, 1.1%]	32

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.615s -> 771.005s (0.05%)
Artifact size: 365.41 MiB -> 365.42 MiB (0.00%)

…instability-lint-for-rustc-middle, r=oli-obk Handle `rustc_middle` cases of `rustc::potential_query_instability` lint This PR removes `#![allow(rustc::potential_query_instability)]` line from [`compiler/rustc_middle/src/lib.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_middle/src/lib.rs#L29) and converts `FxHash{Map,Set}` types into `FxIndex{Map,Set}` to suppress lint errors. A somewhat tracking issue: rust-lang#84447 r? `@compiler-errors`

rustbot assigned compiler-errors Oct 2, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2024

This comment has been minimized.

Sign in to view

ismailarilik marked this pull request as draft October 3, 2024 04:52

This comment has been minimized.

Sign in to view

ismailarilik marked this pull request as ready for review October 3, 2024 09:02

ismailarilik marked this pull request as draft October 4, 2024 08:24

ismailarilik marked this pull request as ready for review October 4, 2024 08:59

rustbot assigned SparrowLii and unassigned compiler-errors Jan 23, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025

rustbot assigned estebank and unassigned SparrowLii Jan 26, 2025

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Feb 26, 2025

This comment has been minimized.

Sign in to view

rustbot unassigned estebank May 1, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2025

oli-obk requested changes May 2, 2025

View reviewed changes

compiler/rustc_middle/src/ty/print/pretty.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2025

Handle rustc_middle cases of rustc::potential_query_instability lint

2426dbc

ismailarilik requested a review from oli-obk May 5, 2025 13:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2025

oli-obk approved these changes May 5, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2025

bors merged commit 7295b08 into rust-lang:master May 6, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone May 6, 2025

Uh oh!

Conversation

ismailarilik commented Oct 2, 2024

Uh oh!

rustbot commented Oct 2, 2024

Uh oh!

rustbot commented Oct 2, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Oct 10, 2024

Uh oh!

bors commented Nov 12, 2024

Uh oh!

compiler-errors commented Jan 23, 2025

Uh oh!

SparrowLii commented Jan 26, 2025

Uh oh!

SparrowLii commented Jan 26, 2025

Uh oh!

Dylan-DPC commented Feb 25, 2025

Uh oh!

This comment has been minimized.

ismailarilik commented Feb 26, 2025

Uh oh!

bors commented Mar 2, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

ismailarilik commented Mar 3, 2025 via email

Uh oh!

oli-obk commented May 1, 2025

Uh oh!

This comment has been minimized.

bors commented May 1, 2025

Uh oh!

bors commented May 1, 2025

Uh oh!

This comment has been minimized.

rust-timer commented May 1, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Uh oh!

oli-obk commented May 5, 2025

Uh oh!

bors commented May 5, 2025

Uh oh!

bors commented May 6, 2025

Uh oh!

bors commented May 6, 2025

Uh oh!

Uh oh!

github-actions bot commented May 6, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented May 6, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants