Remove do_not_const_check from Iterator methods#132368
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 31, 2024
Merged
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
Cc @fee1-dead who added this in #106541 @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#132368 (Remove `do_not_const_check` from `Iterator` methods) - rust-lang#132373 (Make sure `type_param_predicates` resolves correctly for RPITIT) - rust-lang#132374 (Remove dead code stemming from the old effects desugaring) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2024
Rollup merge of rust-lang#132368 - compiler-errors:do-not-iterator, r=tgross35 Remove `do_not_const_check` from `Iterator` methods This attribute is not yet used, but keeping them around seems unnecessarily risky. I don't believe we should be constifying the `Iterator` trait until we've fully thought out how const closures are gonna work and have transitively consified all of its (implementation) dependencies. cc `@rust-lang/project-const-traits` r? libs
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute is not yet used, but keeping them around seems unnecessarily risky. I don't believe we should be constifying the
Iteratortrait until we've fully thought out how const closures are gonna work and have transitively consified all of its (implementation) dependencies.cc @rust-lang/project-const-traits
r? libs