Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attributes from generics in built-in derive macros #132651

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove attributes from generics in built-in derive macros #132651

wants to merge 3 commits into from
+37 −0

Conversation

PonasKovas
Copy link
Contributor

Related issue #132561

Removes all attributes from generics in the expanded implementations of built-in derive macros.

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 5, 2024
@fmease fmease added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Nov 5, 2024
fmease
fmease reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add regression tests for #132561?

@fmease fmease removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Nov 5, 2024
@fmease fmease self-assigned this Nov 5, 2024
@fmease
Copy link
Member

fmease commented Nov 5, 2024 •
edited
Loading

Note to others: This is consistent with the current behavior for type parameters.

I've thought about the change proposed here and while technically technically speaking it's a breaking change, I don't think it's observable by the user -- apart from affecting the emission of lints

  1. which is mostly(?) excluded from Rust's stability guarantees
  2. which is unreachable/masked anyway due to a bug, cc Lint control attributes (allow/deny/etc) have no effect on lifetime and const parameters #61552

@fmease fmease linked an issue Nov 5, 2024 that may be closed by this pull request
Proc-macro helper attributes on lifetime and const parameters fail to resolve if a built-in derive macro is present #132561
Open
@nnethercote nnethercote removed their assignment Nov 6, 2024
@nnethercote
Copy link
Contributor

@fmease, I'll pass the review to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease Awaiting requested review from fmease

Assignees

@fmease fmease

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
4 participants
@PonasKovas @rustbot @fmease @nnethercote