Clean up some FIXME notes on bootstrap#134650
Conversation
|
This PR modifies If appropriate, please update |
11c203e to
eb6e4a7
Compare
| // Generate memcpy, etc. FIXME: Remove this once compiler-builtins | ||
| // automatically detects this target. | ||
|
|
||
| // If zkvm target, generate memcpy, etc. |
There was a problem hiding this comment.
This was asked on the PR for clarity, but no response has been provided.
There was a problem hiding this comment.
cc riscv32im-risc0-zkvm-elf target maintainers @flaub, @jbruestle and @SchmErik: could you elaborate why this is needed or if this is still needed?
Note that riscv32im-risc0-zkvm-elf is a Tier 3 compiler target, and while we would like to avoid unnecessarily breaking stuff we don't have to, we don't offer any guarantees that it will build. We'd like to trim down complexity in the bootstrap codebase where possible, because it's already very very complex.
There was a problem hiding this comment.
@SchmErik Do you recall what this comment was about?
I don't think this is needed anymore.
eb6e4a7 to
d173633
Compare
|
☔ The latest upstream changes (presumably #134830) made this pull request unmergeable. Please resolve the merge conflicts. |
d173633 to
fc15dee
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
fc15dee to
eedafbc
Compare
|
Rebased. @rustbot ready |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e7738af): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.2%, secondary 0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 760.691s -> 760.612s (-0.01%) |
Fixing and removing some FIXME notes.