Skip to content

Document purpose of closure in from_fn.rs more clearly#135886

Merged
bors merged 1 commit intorust-lang:masterfrom
hkBst:patch-14
Jan 28, 2025
Merged

Document purpose of closure in from_fn.rs more clearly#135886
bors merged 1 commit intorust-lang:masterfrom
hkBst:patch-14

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Jan 22, 2025

partial fix for #135087 together with #135895

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@joboet
Copy link
Member

joboet commented Jan 22, 2025

That's very tidy, good idea. Perhaps you could also add a link to the documentation for the next method? Otherwise this seems fine to me.

@joboet
Copy link
Member

joboet commented Jan 24, 2025

Thank you!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 24, 2025

📌 Commit 7328de0 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
@workingjubilee
Copy link
Member

There was really no need to split this and #135895

There was definitely no need to split this into two commits. Please squash.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2025
@workingjubilee workingjubilee self-assigned this Jan 24, 2025
@hkBst
Copy link
Member Author

hkBst commented Jan 26, 2025

squashed
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2025
@workingjubilee
Copy link
Member

Thank you.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 27, 2025

📌 Commit d3cd832 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
@bors bors merged commit 448fa11 into rust-lang:master Jan 28, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 28, 2025
@hkBst hkBst deleted the patch-14 branch February 2, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants