Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• Match Ergonomics 2024: update edition 2024 behavior of feature gates #135434 (Match Ergonomics 2024: update edition 2024 behavior of feature gates)
• simplify similar_tokens from Option<Vec<_>> to &[_] #135882 (simplify similar_tokens from Option<Vec<_>> to &[_])
• Manually walk into WF obligations in BestObligation proof tree visitor #135900 (Manually walk into WF obligations in BestObligation proof tree visitor)
• Allow transmuting generic pattern types to and from their base #136179 (Allow transmuting generic pattern types to and from their base)
• Fix a couple Emscripten tests #136199 (Fix a couple Emscripten tests)
• ci: refactor how directories are removed in free-disk-space disk #136238 (ci: refactor how directories are removed in free-disk-space disk)
• use impl Into<String> instead of explicit type args with bounds #136251 (use impl Into instead of explicit type args with bounds)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=7

[bors]

📌 Commit bfc7127 has been approved by matthiaskrgr

It is now in the queue for this repository.

[matthiaskrgr]

@bors p=5

[rust-log-analyzer]

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#21 exporting to docker image format
#21 sending tarball 27.6s done
#21 DONE 33.6s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---

failures:

---- [ui] tests/ui/typeck/issue-114918/const-in-impl-fn-return-type.rs#next stdout ----
Saved the actual stderr to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/typeck/issue-114918/const-in-impl-fn-return-type.next/const-in-impl-fn-return-type.next.stderr"

9    |
9    |
10 LL |     fn func<const N: u32>() -> [(); N];
11    |                                ^^^^^^^ expected `usize`, found `u32`
+    |
+    = note: the length of array `[(); N]` must be type `usize`
13 error: aborting due to 2 previous errors
14 



The actual stderr differed from the expected stderr.
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args typeck/issue-114918/const-in-impl-fn-return-type.rs`

error in revision `next`: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/typeck/issue-114918/const-in-impl-fn-return-type.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "next" "--check-cfg" "cfg(test,FALSE,current,next)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/typeck/issue-114918/const-in-impl-fn-return-type.next" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver"
--- stderr -------------------------------
error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/typeck/issue-114918/const-in-impl-fn-return-type.rs:20:39
   |
   |
LL |     fn func<const N: u32>() -> [(); { () }] {

error: the constant `N` is not of type `usize`
##[error]  --> /checkout/tests/ui/typeck/issue-114918/const-in-impl-fn-return-type.rs:12:32
   |
   |
LL |     fn func<const N: u32>() -> [(); N];
   |                                ^^^^^^^ expected `usize`, found `u32`
   |
   = note: the length of array `[(); N]` must be type `usize`
error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0308`.
------------------------------------------