-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of rustdoc lints when used with raw doc fragments. #136400
base: master
Are you sure you want to change the base?
Improve handling of rustdoc lints when used with raw doc fragments. #136400
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a9a435b
to
c6d7696
Compare
@fmease what module do you want me to move |
@fmease reminder to look at this. |
@fmease it's been a week, are you going to get to this, or should I reroll reviewers? |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…1, r=<try> Improve handling of rustdoc lints when used with raw doc fragments. 1. `rustdoc::bare_urls` no longer outputs incoherent suggestions if `source_span_for_markdown_range` returns None, instead outputting no suggestion 2. `source_span_for_markdown_range` has one more heuristic, so it will return `None` less often. 3. add ui test to make sure we don't emit nonsense suggestions. fixes rust-lang#135851
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (75eefd1): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -4.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 776.227s -> 775.389s (-0.11%) |
@fmease all recommended changes added |
rustdoc::bare_urls
no longer outputs incoherent suggestions ifsource_span_for_markdown_range
returns None, instead outputting no suggestionsource_span_for_markdown_range
has one more heuristic, so it will returnNone
less often.fixes #135851